Miscellaneous fixes to strings found during i18n work. - #2077
Merged
Conversation
Contributor
Author
|
@dianakhuang @ormsbee @sarina See what I did there? |
Contributor
There was a problem hiding this comment.
Not that the choice of language here is part of your PR but this sentence strikes me as terribly odd. "The decision they returned"?? They referring to the payment processor? And "decision"? Seems like a vague indirect object ("they") and a very, very weird choice of word ("decision"). Not sure if I can even parse to suggest something better.
Contributor
Author
There was a problem hiding this comment.
Yeah, I changed the obvious mistake, and decided not to wade into the more treacherous waters.
Contributor
|
👍 |
Contributor
|
🚢 |
nedbat
added a commit
that referenced
this pull request
Jan 7, 2014
Miscellaneous fixes to strings found during i18n work.
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Aug 8, 2017
shimulch
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Jan 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.