Skip to content

Change default start date for About pages - #2181

Closed
singingwolfboy wants to merge 2 commits into
masterfrom
db/lms-display-about-page-logged-out
Closed

Change default start date for About pages#2181
singingwolfboy wants to merge 2 commits into
masterfrom
db/lms-display-about-page-logged-out

Conversation

@singingwolfboy

Copy link
Copy Markdown
Contributor

So that About pages will display in the LMS if the user is not logged in

@cpennington @dmitchell

So that About pages will display in the LMS if the user is not logged in
@dmitchell

Copy link
Copy Markdown
Contributor

👍 although I'd really like to fix lms to show the about page w/o respect to date if that's what it's supposed to do. I don't believe we allow them to set the start date of the about page.

@cpennington

Copy link
Copy Markdown
Contributor

Does this need to affect any of the other static page types?

@dmitchell

Copy link
Copy Markdown
Contributor

You tell us. Which pages' dates should not disable display but do and why
do they disable display if they shouldn't?

On Wed, Jan 15, 2014 at 3:38 PM, Calen Pennington
notifications@github.comwrote:

Does this need to affect any of the other static page types?


Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/pull/2181#issuecomment-32412365
.

@cpennington

Copy link
Copy Markdown
Contributor

👍

@jzoldak

jzoldak commented Jan 17, 2014

Copy link
Copy Markdown
Contributor

Did this code (and the tests) get merged into master via the release/hotfix branch?

@dmitchell

Copy link
Copy Markdown
Contributor

Not all has been merged and https://github.com/edx/edx-platform/pull/2209 replaces this

@benpatterson
benpatterson deleted the db/lms-display-about-page-logged-out branch January 21, 2015 13:12
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Oct 19, 2017
* fix add note to Zendesk help openedx#2194 (openedx#2202)

* fix add library option, and library links to the course. openedx#2181 (openedx#2205)

* second fix. add library option, and library links to the course. openedx#2210 (openedx#2211)

* third fix. add library option, and library links to the course. openedx#2213 (openedx#2214)

* Add the validation of the due date before 1900 openedx#2188 (openedx#2208)

* Fix bug for biz playback page title openedx#2195 (openedx#2203)

* fix test case. add library option, and library links to the course. openedx#2213 (openedx#2220)

* Add note to page of Password reset confirm. openedx#2216 (openedx#2217)

* Add login code to Playback Status page when the contract using login code openedx#2193 (openedx#2209)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants