Skip to content

enable tests depending on assert is_css_present(css_selector) - #2214

Merged
zubair-arbi merged 1 commit into
openedx:masterfrom
zubair-arbi:zub/story/std1183-staticpagestest
Jan 21, 2014
Merged

enable tests depending on assert is_css_present(css_selector)#2214
zubair-arbi merged 1 commit into
openedx:masterfrom
zubair-arbi:zub/story/std1183-staticpagestest

Conversation

@zubair-arbi

Copy link
Copy Markdown
Contributor

STUD-1183

@cahrens @adampalay @waheedahmed @symbolist
Increase timeout for function "is_css_present" from 10 to 30.

@cahrens

cahrens commented Jan 17, 2014

Copy link
Copy Markdown

@wedaly Do you think this is sufficient?

@wedaly

wedaly commented Jan 17, 2014

Copy link
Copy Markdown
Contributor

@zubair-arbi The changes look reasonable, but it's hard to tell if this will fix the underlying problem without running them repeatedly. I'd recommend running just the failing tests multiple times using this Jenkins job: https://jenkins.testeng.edx.org/job/edx-acceptance-manual-pr/

If they pass consistently, then 👍

@zubair-arbi

Copy link
Copy Markdown
Contributor Author

@wedaly I ran the failing tests at least 5 times (jenkins) each for both course-team and static-pages and all passed successfully every time.

@wedaly

wedaly commented Jan 20, 2014

Copy link
Copy Markdown
Contributor

👍

@cahrens

cahrens commented Jan 21, 2014

Copy link
Copy Markdown

👍 Thanks Zubair-- go ahead and merge.

zubair-arbi added a commit that referenced this pull request Jan 21, 2014
…estest

enable tests depending on assert is_css_present(css_selector)
@zubair-arbi
zubair-arbi merged commit 7bdcc84 into openedx:master Jan 21, 2014
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Oct 19, 2017
* fix add note to Zendesk help openedx#2194 (openedx#2202)

* fix add library option, and library links to the course. openedx#2181 (openedx#2205)

* second fix. add library option, and library links to the course. openedx#2210 (openedx#2211)

* third fix. add library option, and library links to the course. openedx#2213 (openedx#2214)

* Add the validation of the due date before 1900 openedx#2188 (openedx#2208)

* Fix bug for biz playback page title openedx#2195 (openedx#2203)

* fix test case. add library option, and library links to the course. openedx#2213 (openedx#2220)

* Add note to page of Password reset confirm. openedx#2216 (openedx#2217)

* Add login code to Playback Status page when the contract using login code openedx#2193 (openedx#2209)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants