Rename values in SiteConfiguration/History (1/3) - #22692
Conversation
9bd4e92 to
e542cd9
Compare
bmedx
left a comment
bmedx
left a comment
There was a problem hiding this comment.
Seems fine to me. Only nit is that some places have TODOs and others don't. Not a big deal since presumably 2/3 and 3/3 will be hot on the heels of this one.
e542cd9 to
84ca5af
Compare
- Adds the new field and migration to create the column. - Makes all writes go to both old and new field.
84ca5af to
05f2e39
Compare
|
Your PR has finished running tests. There were no failures. |
This reverts commit cebeab4.
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/STAGE_edxapp_M-D |
|
EdX Release Notice: This PR has been deployed to the production environment. |
This reverts commit 84de6bc which reverts commit cebeab4 which implements the first stage of the `values` column rename in SiteConfiguration. However, I included a small change: This time, we set a default value on the new `site_values` column so that the ORM will happily deserialize the JSONField without throwing a JSONDecodeError.
5 participants
https://openedx.atlassian.net/browse/DE-1826
This stage does the following:
Stage 1: this PR.
Stage 2: #22709
Stage 3: #22753
Testing plan detailed in https://openedx.atlassian.net/wiki/spaces/DE/pages/1065681172/Patterns+For+Renaming+Django+Model+Fields#PatternsForRenamingDjangoModelFields-RolloutPlanForCreditRequirement.orderIntheLMS