Skip to content

Rename values in SiteConfiguration/History (3/3) - #22753

Merged
pwnage101 merged 1 commit into
masterfrom
juliasq/rename_site_configuration_siteconfiguration_values_3
Mar 9, 2020
Merged

Rename values in SiteConfiguration/History (3/3)#22753
pwnage101 merged 1 commit into
masterfrom
juliasq/rename_site_configuration_siteconfiguration_values_3

Conversation

@doctoryes

@doctoryes doctoryes commented Jan 7, 2020

Copy link
Copy Markdown
Contributor

https://openedx.atlassian.net/browse/DE-1826

This stage does the following:

  • Includes a migration to delete the old values column.
  • Remove the test skip for test_migrations_are_in_sync

Stage 1: #22692 #23144 (first attempt, second attempt)
Stage 2: #22709 #22851 #23206 #23214 #23224 #23236 #23306 (first attempt, first attempt again, revert, second attempt, revert, fix-forward, third attempt)
Stage 3: this PR

@doctoryes
doctoryes force-pushed the juliasq/rename_site_configuration_siteconfiguration_values_2 branch from 01bfcf5 to 659cea7 Compare January 14, 2020 15:59
@pwnage101
pwnage101 force-pushed the juliasq/rename_site_configuration_siteconfiguration_values_2 branch 2 times, most recently from 3e65873 to 6d0945c Compare February 21, 2020 22:21
@pwnage101
pwnage101 force-pushed the juliasq/rename_site_configuration_siteconfiguration_values_3 branch from 25d21fb to e3cbdd8 Compare February 21, 2020 22:25
@pwnage101
pwnage101 force-pushed the juliasq/rename_site_configuration_siteconfiguration_values_2 branch 4 times, most recently from b4655da to 3541643 Compare February 25, 2020 18:54
@pwnage101
pwnage101 force-pushed the juliasq/rename_site_configuration_siteconfiguration_values_3 branch from e3cbdd8 to 4444ffb Compare March 6, 2020 17:43
@doctoryes
doctoryes requested review from a team March 6, 2020 17:43
@doctoryes
doctoryes requested a review from a team as a code owner March 6, 2020 17:43
@doctoryes
doctoryes requested review from a team March 6, 2020 17:43
@doctoryes
doctoryes requested a review from a team as a code owner March 6, 2020 17:43
@doctoryes
doctoryes requested a review from a team March 6, 2020 17:43
@pwnage101
pwnage101 changed the base branch from juliasq/rename_site_configuration_siteconfiguration_values_2 to master March 6, 2020 17:43
@openedx openedx deleted a comment from doctoryes Mar 6, 2020
@openedx openedx deleted a comment from edx-status-bot Mar 6, 2020
@pwnage101
pwnage101 requested review from pwnage101 and removed request for a team March 6, 2020 17:48
@pwnage101

Copy link
Copy Markdown
Contributor

jenkins run a11y

@edx-status-bot

Copy link
Copy Markdown

Your PR has finished running tests. There were no failures.

@doctoryes

Copy link
Copy Markdown
Contributor Author

👍 but can't officially approve due to me creating the PR.

@pwnage101
pwnage101 merged commit 02d8913 into master Mar 9, 2020
@pwnage101
pwnage101 deleted the juliasq/rename_site_configuration_siteconfiguration_values_3 branch March 9, 2020 13:32
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants