Rename values in SiteConfiguration (2/3) - #22851
Merged
pwnage101 merged 1 commit intoFeb 26, 2020
Merged
Conversation
pwnage101
force-pushed
the
juliasq/rename_site_configuration_siteconfiguration_values_2
branch
2 times, most recently
from
February 21, 2020 22:21
3e65873 to
6d0945c
Compare
Contributor
|
This is still missing a data migration for the history table, that's coming soon... |
pwnage101
force-pushed
the
juliasq/rename_site_configuration_siteconfiguration_values_2
branch
2 times, most recently
from
February 24, 2020 19:21
61a3ae8 to
f8c801c
Compare
Contributor
|
jenkins run a11y |
pwnage101
force-pushed
the
juliasq/rename_site_configuration_siteconfiguration_values_2
branch
from
February 25, 2020 17:14
f8c801c to
b4655da
Compare
doctoryes
commented
Feb 25, 2020
doctoryes
left a comment
doctoryes
left a comment
Contributor
Author
There was a problem hiding this comment.
I can't approve this PR since I opened it 😁 - but 👍
This stage does the following: - Includes a data migration to copy the values from old to new field. - Changes business logic to switch to using new field. - Deletes all code references of the old field.
pwnage101
force-pushed
the
juliasq/rename_site_configuration_siteconfiguration_values_2
branch
from
February 25, 2020 18:54
b4655da to
3541643
Compare
|
Your PR has finished running tests. There were no failures. |
pwnage101
requested review from
HassanJaveed84,
bmedx,
brianhw,
estute,
hunytalk and
macdiesel
February 25, 2020 19:19
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
edx-secure
deleted the
juliasq/rename_site_configuration_siteconfiguration_values_2
branch
March 8, 2020 15:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stage does the following:
Please consider the following when opening a pull request:
In each commit, include description that could help a developer
several months from now.
make upgrade, run as close to the time of merging as possibleto avoid accidentally downgrading someone else's package.
Put the output of
make upgradein its own separate commit,decoupled from other code changes.
automated testing isn't a substitute for manual verification.
Code that is amenable to refactoring and improvement benefits all platform developers,
especially given the size and scope of edx-platform.
Consult existing Architectural Decision Records (ADRs),
including those concerning the app(s) you are changing and
those concerning edx-platform as a whole.