Learner-2041: remove logout view configuration - #23508
Conversation
|
Thanks for the pull request, @cldme! I've created OSPR-4319 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
@cldme Thank you for your contribution. Please let me know once all tests are green. |
|
jenkins run all |
|
jenkins run js |
1 similar comment
|
jenkins run js |
|
@dianakhuang Can you have a look at this when you have a chance? |
|
@cldme Awesome! Thanks for submitting this! Unfortunately, it would be best for us to split out your two commits into two separate PRs. One to remove the code and one to include the migration that removes the model. Please feel free to tag me on the second PR directly if you manage to pick this up! |
|
@dianakhuang Hi, thanks for your reply. Sure, I can split up this PR in two separate ones. I will ping you once that's done. Thanks. |
|
@cldme Pinging to see if you are still interested in pursuing this. |
|
Your PR has finished running tests. The following contexts failed:
|
|
@cldme I have not heard from you in a while, so I am closing for now. Please feel free to re-open if you decide to pursue this again. |
|
@cldme Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Jira issue: LEARNER-2041
Description: removed the LogoutViewConfiguration. The functionality has been rolled out, and is no longer needed (code was deprecated)
Studio updates: None
LMS updates: None
Note: there are two commits in this pull request, the first one contains the removal of the code and in the second commit the migration file was added.
Discussion thread: discuss.openedx.org/t/remove-logoutviewconfiguration-model/1575