Skip to content

Learner-2041: remove logout view configuration - #23508

Closed
tomdevman wants to merge 2 commits into
openedx:masterfrom
tomdevman:LEARNER-2041_remove_logout_view_configuration
Closed

Learner-2041: remove logout view configuration#23508
tomdevman wants to merge 2 commits into
openedx:masterfrom
tomdevman:LEARNER-2041_remove_logout_view_configuration

Conversation

@tomdevman

Copy link
Copy Markdown
Contributor

Jira issue: LEARNER-2041

Description: removed the LogoutViewConfiguration. The functionality has been rolled out, and is no longer needed (code was deprecated)

Studio updates: None

LMS updates: None

Note: there are two commits in this pull request, the first one contains the removal of the code and in the second commit the migration file was added.

Discussion thread: discuss.openedx.org/t/remove-logoutviewconfiguration-model/1575

@tomdevman
tomdevman requested a review from a team March 26, 2020 22:48
@openedx-webhooks

openedx-webhooks commented Mar 26, 2020

Copy link
Copy Markdown

Thanks for the pull request, @cldme! I've created OSPR-4319 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Mar 26, 2020
@natabene

Copy link
Copy Markdown
Contributor

@cldme Thank you for your contribution. Please let me know once all tests are green.

@natabene

Copy link
Copy Markdown
Contributor

jenkins run all

@openedx-webhooks openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels Mar 27, 2020
@tomdevman

Copy link
Copy Markdown
Contributor Author

jenkins run js

1 similar comment
@natabene

Copy link
Copy Markdown
Contributor

jenkins run js

@natabene

Copy link
Copy Markdown
Contributor

@dianakhuang Can you have a look at this when you have a chance?

@openedx-webhooks openedx-webhooks added awaiting prioritization and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Mar 29, 2020
@dianakhuang

Copy link
Copy Markdown
Contributor

@cldme Awesome! Thanks for submitting this! Unfortunately, it would be best for us to split out your two commits into two separate PRs. One to remove the code and one to include the migration that removes the model. Please feel free to tag me on the second PR directly if you manage to pick this up!

@tomdevman

Copy link
Copy Markdown
Contributor Author

@dianakhuang Hi, thanks for your reply. Sure, I can split up this PR in two separate ones. I will ping you once that's done. Thanks.

@natabene

Copy link
Copy Markdown
Contributor

@cldme Pinging to see if you are still interested in pursuing this.

@edx-status-bot

Copy link
Copy Markdown

Your PR has finished running tests. The following contexts failed:

  • jenkins/python-3.8/a11y
  • jenkins/python-3.8/js
  • jenkins/python-3.8/python
  • jenkins/python-3.8/quality
  • codecov/project

@natabene

Copy link
Copy Markdown
Contributor

@cldme I have not heard from you in a while, so I am closing for now. Please feel free to re-open if you decide to pursue this again.

@openedx-webhooks

Copy link
Copy Markdown

@cldme Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U rejected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants