LEARNER-2041: Remove deprecated LogoutViewConfiguration from student models - #23541
Conversation
|
Thanks for the pull request, @cldme! I've created OSPR-4336 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here. |
|
@dianakhuang Hi, this pull request contains the removal of the code for the deprecated logout view configuration. I think you need to trigger the jenkins tests as well since I don't have permissions yet. Could you have a look over it? Let me know if there are any problems. Thanks. |
|
jenkins run all |
|
jenkins run all |
|
@cldme Thanks for your contribution! |
|
Whoops, @cldme , I forgot to mention that you might need to add a |
496ba0f to
11ca56d
Compare
|
Hi @dianakhuang, I added the |
|
jenkins run all |
1 similar comment
|
jenkins run all |
11ca56d to
765a686
Compare
|
Hi @dianakhuang, I think the code should be ok now, can you please trigger the tests again. Thanks! |
|
jenkins run all |
|
Your PR has finished running tests. There were no failures. |
|
@cldme 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Jira issue: LEARNER-2041
Description: removed the LogoutViewConfiguration. The functionality has been rolled out, and is no longer needed (code was deprecated)
Studio updates: None
LMS updates: None
Note: there is one commit in this pull request which contains the removal of the code
Discussion thread: discuss.openedx.org/t/remove-logoutviewconfiguration-model/1575
Note: see discussion from this pull request: #23508