SE-3149 Fix the theme compilation issue in juniper - #24972
Conversation
|
Thanks for the pull request, @pkulkark! I've created OSPR-4966 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
jenkins run all |
|
👍
|
|
@pkulkark Thank you for your contribution. Please let me know once this is ready for our review. |
|
@natabene I can't seem to get the jenkins tests running. Could you trigger it for me? Thanks! |
|
jenkins run all |
|
Does this correspond to a change on master? Does master need the same fix? |
|
@nedbat Yes it looks like master will need the same fix. This would need to be present since the juniper release so should I create another PR against master? |
|
@pkulkark Generally we prefer fixes to go on master first, and then be cherry-picked onto the release branch. This helps confirm the fix. |
|
@pkulkark Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
|
Your PR has finished running tests. The following contexts failed:
|
CachedStaticFilesStorageis deprecated in Django 2.2. It's plugin model i.e.CachedFilesMixinwas being used in theme asset compilation. This was leading to inconsistent theme asset compilation and would lead to failures if more than one instance is used for load-balancing. This PR replaces the deprecatedCachedFilesMixinwithManifestFilesMixin. It also fixes the order of the modules used in compilation.Jira Tickets: OSPR-4966
Dependecies: None
Sandbox URL: TBD - sandbox is being provisioned
Merge deadline: None
Testing Instructions:
paver update_assetscommand and recheck that no new css files are generated in /edx/var/edxapp/staticfiles/css.Reviewers: