[SE-3401] Updates BuildTools UglifyJS configuration to be consistent on different machines - #274
Closed
nizarmah wants to merge 4343 commits into
Closed
[SE-3401] Updates BuildTools UglifyJS configuration to be consistent on different machines#274nizarmah wants to merge 4343 commits into
nizarmah wants to merge 4343 commits into
Conversation
The XBlockPackageStorage used to return offset-naive datetime objects
which were compared to offset-aware objects when we ran static asset
collection:
./manage.py lms collectstatic
Close CRI-191
* Fix all stylelint errors For any errors that fixing would require changing the output of the css disable stylelint for that line instead of modifying. * Update quality.py Make stylelint quality check pass when there are no errors * Delete empty selectors
…static-assets Fix naive offset-naive/aware error in asset compilation [CRI-191]
This reverts commit 2ddc35c.
…rollment-sync-support-tool MST-181: Add the ability to unlink and relink Program Enrollments via Support Tool to Address SSO Issues
…y auth config fetching (openedx#23824)" (openedx#23935) This reverts commit 7942064.
…querade-on-dates-tab Enable masquerade on dates tab
…lated-text Missing translation function call
Allows user to type in phone number in whichever format they prefer.
Apply same username restrictions during SSO pipeline as we have user registeration flow to avoid SSO flow breakage at the time of user creation. ENT-2730 Code quality fixes
Strip non-numeric characters from phone number
Enable access role in django admin
Constrain ddt<1.4.0 until this issue is fixed: - datadriventests/ddt#83
…38-banner-debug Revert "add logs for debugging"
* Commits: Revert "Add logging to Learning MFE iframe, temporarily"
…ring - removal happens post static validation
Bump edx-enterprise to 3.2.8
ENT-2730: Apply same username restrictions during SSO pipeline
Sustaining/security fixes 4 (cherry picked from commit e637704)
Sustaining/security fixes 5 (cherry picked from commit f87e1d2)
BB-2941 Latest batch of XSS fixes
This is required to stop get_course_about_section html content from using the edxnotes version of get_html, which injects the edxnotes html into it. We don't want this injected into the html here, because these are snippets meant to be displayed in original form on the course about page.
This fixes the error thrown when trying to download the list of all users, staff and instructors from the Sysadmin dashboard
Jira ticket: SE-3248 Upstream pull request: openedx#25038
…vents [SE-3248] Add progress_video event and update tests Upstream pull request: edx#25038
* docs(lms and studio): Replace all .(lms|cms).(\w+|_)?\.json to .(lms|cms).(\w+|_)?\.yml * refactor(lms): Update migrations to use lms.yml in the help text
…tion-juniper SE-3243 Use original get_html for AboutBlock
…ashboard-csv-download-fix [BB-3057] Use BytesIO as unicodecsv expects a bytestream, not unicode
…vents [SE-3248] Update video progression events to 5-range instead of decade
Cherry pick fix for Studio file upload issues
Author
|
This is embarrassing 😳 I thought I updated the branch, but I guess my internet connection is too slow. Sorry everyone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating the minified files for the TinyMCE static files using the
vendor_extra/tinymce/JakePackage.zip, there's often a problem that was happening where the files are different after running the following command:This becomes an issue when installing a new TinyMCE plugin on different machines and re-running
jake minify bundle, because the files are not consistent on different machines. This results in a differentcommons.jsfile hash on the different machines, which makes it not possible to use multiple instances with a load balancer.There are other reasons why the
commons.jsfile hash is different, which are mentioned in PR edx#24972Therefore, this is a follow-up PR to openedx#24972.
This PR simply adds a specific configuration for
uglify-js, which is:One of the most important is,
sortwhich makes the mangled variable names consistent on different runs. Also,comparisonsandif_returnare specified because they were sometimes applied, while others times, they weren't.JIRA tickets: SE-3401, SE-3101, SE-3381
Upstream PR: edx#25324
Testing instructions:
common/static/js/vendor/tinymce/unzip ../../../../../vendor_extra/tinymce/JakePackage.ziprm -rf node_modulesnpm installAuthor notes and concerns:
Reviewers