Rename more "custom metric" references to "custom attribute" - #25018
Conversation
This fixes a misuse of New Relic terminology. Here we are in fact using custom attributes; custom metrics are a different thing that we may start using in the future.
|
@timmc-edx: In case you missed this in Slack, it should be fine to update |
This changes: - `WAFFLE_FLAG_CUSTOM_METRICS` - `WaffleFlagNamespace._set_waffle_flag_metric` - `_get_waffle_flag_custom_metrics_set` and some other unreferenced internals
|
(Conflicts are because #25010 has been reverted; that one should be replayed before a merge is attempted on this one.) |
|
jenkins run all |
robrap
left a comment
robrap
left a comment
There was a problem hiding this comment.
Thanks. Approved once it is green.
# Conflicts: # cms/envs/common.py # lms/envs/common.py
|
Your PR has finished running tests. There were no failures. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
4 participants
This fixes a misuse of New Relic terminology. We are in fact using
custom attributes; custom metrics are a different thing that we may start
using in the future.