Skip to content

ARCHBOM-1494: Refer to custom attributes, not metrics, especially with edx-django-utils - #25010

Merged
timmc-edx merged 7 commits into
masterfrom
timmc/metric-attribute
Sep 18, 2020
Merged

ARCHBOM-1494: Refer to custom attributes, not metrics, especially with edx-django-utils#25010
timmc-edx merged 7 commits into
masterfrom
timmc/metric-attribute

Conversation

@timmc-edx

@timmc-edx timmc-edx commented Sep 17, 2020

Copy link
Copy Markdown
Contributor

This uses the new names introduced in edx-django-utils 3.8.0 (openedx/edx-django-utils#59), which we're already using, as well as updating a few other locations where we incorrectly refer to New Relic custom metrics instead of custom attributes.

@timmc-edx

timmc-edx commented Sep 17, 2020

Copy link
Copy Markdown
Contributor Author

Other references to "metric" in the codebase break down into:

  • Similarly misnamed things that could require different code changes:
    • openedx/core/lib/request_utils.py (CookieMetricsMiddleware)
    • lms/djangoapps/courseware/user_state_client.py (_nr_* methods)
    • openedx/core/djangoapps/waffle_utils/__init__.py (WAFFLE_FLAG_CUSTOM_METRICS and related)
  • Various dangling references to datadog metrics collection that can be deleted (unused variables)
  • Irrelevant stuff

@edx-status-bot

edx-status-bot commented Sep 17, 2020

Copy link
Copy Markdown

Your PR has finished running tests. There were no failures.

@timmc-edx
timmc-edx merged commit ba9ee4e into master Sep 18, 2020
@timmc-edx
timmc-edx deleted the timmc/metric-attribute branch September 18, 2020 13:33
@AhtishamShahid AhtishamShahid mentioned this pull request Sep 21, 2020
Merged
AhtishamShahid added a commit that referenced this pull request Sep 21, 2020
@AhtishamShahid
Revert "ARCHBOM-1494: Refer to custom attributes, not metrics, especi…
55b0e1c 
…ally with edx-django-utils (#25010)"

This reverts commit ba9ee4e.

Fixed Style lint issue
AhtishamShahid added a commit that referenced this pull request Sep 21, 2020
@AhtishamShahid
Revert "ARCHBOM-1494: Refer to custom attributes, not metrics, especi…
986a448 
…ally with edx-django-utils (#25010)" (#25025)

This reverts commit ba9ee4e.

Fixed Style lint issue
@edx-pipeline-bot

edx-pipeline-bot commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

edx-pipeline-bot commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage

@robrap

robrap commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

@timmc-edx @feanil: I was expecting to do this as part of my observability work, but this was a nice little treat to return to. Thank you!

@timmc-edx

timmc-edx commented Sep 21, 2020

Copy link
Copy Markdown
Contributor Author

Don't worry, I left some for you!

@edx-pipeline-bot

edx-pipeline-bot commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@edx-pipeline-bot

edx-pipeline-bot commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been rolled back from the production environment.

@edx-pipeline-bot

edx-pipeline-bot commented Sep 22, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@edx-pipeline-bot

edx-pipeline-bot commented Sep 22, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been rolled back from the production environment.

@edx-pipeline-bot

edx-pipeline-bot commented Sep 22, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@timmc-edx timmc-edx mentioned this pull request Sep 23, 2020
Merged
timmc-edx added a commit that referenced this pull request Sep 23, 2020
@timmc-edx
Revert "Revert "ARCHBOM-1494: Refer to custom attributes, not metrics…
d5bb740 
…, especially with edx-django-utils (#25010)" (#25025)"

This reverts commit 986a448.
@timmc-edx timmc-edx mentioned this pull request Sep 23, 2020
Merged
timmc-edx added a commit that referenced this pull request Sep 28, 2020
@timmc-edx
Revert "Revert "ARCHBOM-1494: Refer to custom attributes, not metrics…
f29e418 
…, especially with edx-django-utils (#25010)" (#25025)" (#25055)

This reverts commit 986a448.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feanil feanil feanil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@timmc-edx @edx-status-bot @edx-pipeline-bot @robrap @feanil