Skip to content

Revert "ARCHBOM-1494: Refer to custom attributes, not metrics, especially with edx-django-utils" - #25025

Merged
AhtishamShahid merged 1 commit into
masterfrom
revert-25010-timmc/metric-attribute
Sep 21, 2020
Merged

Revert "ARCHBOM-1494: Refer to custom attributes, not metrics, especially with edx-django-utils"#25025
AhtishamShahid merged 1 commit into
masterfrom
revert-25010-timmc/metric-attribute

Conversation

@AhtishamShahid

@AhtishamShahid AhtishamShahid commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

Reverts edx/edx-platform#25010

@AhtishamShahid
Revert "ARCHBOM-1494: Refer to custom attributes, not metrics, especi…
55b0e1c 
…ally with edx-django-utils (#25010)"

This reverts commit ba9ee4e.

Fixed Style lint issue
@AhtishamShahid
AhtishamShahid force-pushed the revert-25010-timmc/metric-attribute branch from dcacada to 55b0e1c Compare September 21, 2020 08:02
@edx-status-bot

edx-status-bot commented Sep 21, 2020

Copy link
Copy Markdown

Your PR has finished running tests. There were no failures.

@AhtishamShahid
AhtishamShahid merged commit 986a448 into master Sep 21, 2020
@AhtishamShahid
AhtishamShahid deleted the revert-25010-timmc/metric-attribute branch September 21, 2020 08:48
@edx-pipeline-bot

edx-pipeline-bot commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

edx-pipeline-bot commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage

@edx-pipeline-bot

edx-pipeline-bot commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@edx-pipeline-bot

edx-pipeline-bot commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been rolled back from the production environment.

@edx-pipeline-bot

edx-pipeline-bot commented Sep 22, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@edx-pipeline-bot

edx-pipeline-bot commented Sep 22, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been rolled back from the production environment.

@edx-pipeline-bot

edx-pipeline-bot commented Sep 22, 2020

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

timmc-edx added a commit that referenced this pull request Sep 23, 2020
@timmc-edx
Revert "Revert "ARCHBOM-1494: Refer to custom attributes, not metrics…
d5bb740 
…, especially with edx-django-utils (#25010)" (#25025)"

This reverts commit 986a448.
@timmc-edx timmc-edx mentioned this pull request Sep 23, 2020
Merged
timmc-edx added a commit that referenced this pull request Sep 28, 2020
@timmc-edx
Revert "Revert "ARCHBOM-1494: Refer to custom attributes, not metrics…
f29e418 
…, especially with edx-django-utils (#25010)" (#25025)" (#25055)

This reverts commit 986a448.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AhtishamShahid @edx-status-bot @edx-pipeline-bot