fix: AA-646: Fix is_staff_user check to check for course staff - #27407
Merged
Dillon-Dumesnil merged 1 commit intoApr 26, 2021
Merged
Conversation
MatthewPiatetsky
approved these changes
Apr 23, 2021
Contributor
Author
|
jenkins run all |
It was checking for global staff, but really only needed to check for course staff. This corrects the check
Dillon-Dumesnil
force-pushed
the
ddumesnil/fix-staff-access-aa-646-lilac
branch
from
April 23, 2021 15:31
00f5c19 to
eb2e9ac
Compare
Contributor
Author
|
Not sure why tests aren't running on this PR, but as long as tests pass on the related PR for master, I'm going to treat this PR as also passing. The most recent force push was just a text change in the commit to see if I could trigger tests. |
sambapete
added a commit
to EDUlib/edx-platform
that referenced
this pull request
Apr 30, 2021
…aa-646-… …lilac fix: AA-646: Fix is_staff_user check to check for course staff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was checking for global staff, but really only needed to check
for course staff. This corrects the check.
https://openedx.atlassian.net/browse/AA-646
Corresponding fix in master: https://github.com/edx/edx-platform/pull/27406