Skip to content

fix: AA-646: Fix is_staff_user check to check for course staff #27407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dillon-Dumesnil merged 1 commit into from
Apr 26, 2021
Merged

fix: AA-646: Fix is_staff_user check to check for course staff #27407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common/lib/xmodule/xmodule/modulestore/search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

from logging import getLogger


from lms.djangoapps.courseware.access import has_access
from lms.djangoapps.courseware.masquerade import MASQUERADE_SETTINGS_KEY
from common.djangoapps.student.roles import GlobalStaff
from .exceptions import ItemNotFoundError, NoPathToItem
Expand Down Expand Up @@ -130,7 +130,7 @@ def get_child_locations(section_desc, request, course_id):
Returns all child locations for a section. If user is learner or masquerading as learner,
staff only blocks are excluded.
"""
is_staff_user = GlobalStaff().has_user(request.user) if request else False
is_staff_user = has_access(request.user, 'staff', course_id).has_access if request else False

def is_masquerading_as_student():
"""
Expand Down