Moved xml_store_config, mongo_store_config, and draft_mongo_store_config... - #307
Merged
Conversation
Contributor
|
As far as making the tests parallel goes... it looks good. Though I do wonder about the database name (see line comment) |
Contributor
There was a problem hiding this comment.
Should the db be called test_xmodule for consistency?
Contributor
|
I know I said it was okay to move the In In So the directory structure should be this:
|
Contributor
|
👍 |
…fig to xmodule/modulestore/tests/django_util.py Removed some repeated instances of xml_store_config. Reverted some changes to mongo_store_config so each modulestore gets it's own uuid.
jmnater
pushed a commit
that referenced
this pull request
Jul 1, 2013
Moved xml_store_config, mongo_store_config, and draft_mongo_store_config...
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
Kimth/lms coderesponse
hachiyanagi-ks
added a commit
to nttks/edx-platform
that referenced
this pull request
Oct 2, 2015
hachiyanagi-ks
added a commit
to nttks/edx-platform
that referenced
this pull request
Oct 2, 2015
…x-messages-account-settings Fix messages for account settings openedx#307
CrewS
pushed a commit
to CrewS/edx-platform-1
that referenced
this pull request
Feb 18, 2019
michaelroytman
added a commit
that referenced
this pull request
Nov 30, 2022
…Service and Result Service This commit upgrades the version of the lti-consumer-xblock library from version 6.4.0 to version 7.0.2. This includes versions 7.0.0, 7.0.1, and 7.0.2. Version 7.0.0 includes refactoring to remove deprecated method calls to rebind_noauth_module_to_user, get_real_user, runtime.hostname, and runtime.course_id. Version 7.0.1 includes a fix to the clean method of the LtiConfiguration model. The fix changes the way we look up the course ID so that we can access the course ID without needing to load the XBlock. Version 7.0.2 includes fixes to LTI 1.1 Basic Outcomes Services and LTI 2.0 Result Service when using an external_user_id as a user identifier. Note that version 7.0.1 was originally deployed in #31369. It was reverted soon after in #31377. The issue occurred in version 7.0.0, in the following line https://github.com/openedx/xblock-lti-consumer/pull/249/files#diff-ab027143adc95b9776c12e973e28f025a21b0d88112937af93645829686527fdL186. self in the call to the service is an instance of the OutcomeService. self should be an instance of an XBlock (i.e. LtiConsumerXBlock). Version 7.0.2 fixes this bug by moving the call to the service to the LtiConsumerXBlock, where self is an instance of an XBlock. Therefore, we are deploying this version to fix forward. Please see the CHANGELOG entries below for these versions for a full description of the changes. Version 7.0.0: https://github.com/openedx/xblock-lti-consumer/blob/master/CHANGELOG.rst#700---2022-11-29 Version 7.0.1: https://github.com/openedx/xblock-lti-consumer/blob/master/CHANGELOG.rst#701---2022-11-29 Version 7.0.2: https://github.com/openedx/xblock-lti-consumer/blob/master/CHANGELOG.rst#702---2022-11-29. The commit messages of each version are included below for convenience. 7.0.0 ----- refactor: replace block.location with block.scope_ids.usage_id 7.0.1 ----- fix: do not attempt to load the block just to look at the location the block is not loadable in exams so clean fails in that IDA, but we shouldn't need the block to ask a question about the course 7.0.2 ----- In #307, we added the ability to send a stable, static user identifier (i.e. external user ID) to fix failed launches with the QwikLabs tool. This is because the QwikLabs tool did not work with the course-anonymized user IDs we used to send (i.e. anonymous user IDs). Inadvertently, this change broke the LTI 1.1 Basic Outcomes Service and the LTI 2.0 Result Service for courses that use the external user ID (i.e. they have the lti_consumer.enable_external_user_id_1p1_launches CourseWaffleFlag enabled). The Basic Outcomes Service and Result Service handle grade pass backs. Because we now have two ways to identify a user in LTI 1.1/2.0, we must update the Basic Outcomes Service and Result Service to support both. This commit fixes this bug.
Danyal-Faheem
pushed a commit
to Danyal-Faheem/edx-platform
that referenced
this pull request
Jul 15, 2025
update locale from the openedx/maple.master branch
kiram15
pushed a commit
that referenced
this pull request
Jul 17, 2026
…d… (#307) * fix: upgrade ora2 dependency to version 7.0.0 and remove loremipsum dependency * fix: update ora2 dependency to version 7.0.0 and remove loremipsum dependency * fix: downgrade ora2 dependency to version 6.17.2 across multiple requirements files * fix: improve translation extraction process in Makefile * fix: streamline translation extraction process and downgrade ora2 dependency * fix: enhance translation extraction process in Makefile --------- Co-authored-by: alenkadev <alenka-sonata@2u.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... to xmodule/modulestore/tests/django_util.py
Removed some repeated instances of xml_store_config.
Reverted some changes to mongo_store_config so each modulestore gets it's own uuid.
@JonahStanley @jzoldak @wedaly