Use $WORKON_HOME consistently for virtualenv. - #377
Merged
Conversation
Some parts of the `create-dev-env/sh` script use `$WORKON_HOME` and others hardcode `$HOME/.virtualenvs` which means if you **don't** put your virtualenvs under `$HOME/.virtualenvs`, the script doesn't work at all. This commit removes the hardcoding of virtualenv location and consistently uses `$WORKON_HOME` everywhere.
Contributor
|
Looks good (glad to see this). |
jtauber
added a commit
that referenced
this pull request
Jul 12, 2013
Use $WORKON_HOME consistently for virtualenv.
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
wayfinding style changes
antoviaque
referenced
this pull request
in open-craft/openedx-platform
Jan 23, 2015
Merge release into master
hachiyanagi-ks
added a commit
to nttks/edx-platform
that referenced
this pull request
Oct 2, 2015
…x-messages-account-settings Fix messages for account settings openedx#307
diegomillan
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Sep 14, 2016
…quirement_for_client Update requirements for analytics-api-client that has an increased timeout.
yoann-mroz
pushed a commit
to weuplearning/edx-platform
that referenced
this pull request
Nov 30, 2020
openedx#377) * Initialize comprehensive theming volumes for devstack_docker services to also include watchers. * Initialize comprehensive theming volumes for devstack_docker services to include all services that include a `docker-compose-host.yml`.
Danyal-Faheem
pushed a commit
to Danyal-Faheem/edx-platform
that referenced
this pull request
Jul 15, 2025
Signed-off-by: GitHub <noreply@github.com> Co-authored-by: Ali-Salman29 <Ali-Salman29@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some parts of the
create-dev-env/shscript use$WORKON_HOMEandothers hardcode
$HOME/.virtualenvswhich means if you don't putyour virtualenvs under
$HOME/.virtualenvs, the script doesn't work atall.
This commit removes the hardcoding of virtualenv location and
consistently uses
$WORKON_HOMEeverywhere.