fix: remove language_session_key usage - #32578
Conversation
e34641a to
ed654b3
Compare
ed654b3 to
b63b6e1
Compare
robrap
left a comment
robrap
left a comment
There was a problem hiding this comment.
A better PR description would have been helpful. It took me a while to realize LANGUAGE_COOKIE_NAME was not new in this PR. I thought we were transitioning from LANGUAGE_SESSION_KEY to LANGUAGE_COOKIE_NAME, and maybe we are, but just not all in this PR? Are all the test changes because we didn't have as much LANGUAGE_COOKIE_NAME test coverage as we'd like, and now we are adding it?
Note: I do not have expertise in this area, so this is just a general review. When my review is complete, you can determine if you want someone with more language-related expertise.
|
@UsamaSadiq @iamsobanjaved: Please ping me when you want me to review again. Also, I'd appreciate quick replies to my comments (when you are ready), which might be "Done", or whatever is appropriate. Sometimes comments are marked "Outdated" due to changes, but the comment itself was never actually addressed. Thank you. |
robrap
added
the
waiting on author
robrap
left a comment
robrap
left a comment
There was a problem hiding this comment.
I'm not sure if you were ready for review, but I saw changes, so decided to take a look. Thanks.
d64e47a to
bff7f48
Compare
c11bfac to
27edbc6
Compare
|
@robrap this is ready for review now |
robrap
added
ready to merge
and removed
waiting on author
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
This is a patch to pull request openedx#32578 because the `session_language` was renamed to `update_language` except in three locations causing a 500 error: Reverse for 'session_language' not found. 'session_language' is not a valid view function or pattern name
5 participants
Description
This PR intends to resolve the issue #32388.