Skip to content

fix: session_language url renamed to update_language - #33729

Merged
navinkarkera merged 1 commit into
openedx:masterfrom
open-craft:navin/fix-url-rename
Nov 23, 2023
Merged

fix: session_language url renamed to update_language#33729
navinkarkera merged 1 commit into
openedx:masterfrom
open-craft:navin/fix-url-rename

Conversation

@navinkarkera

Copy link
Copy Markdown
Contributor

Description

The url was renamed from session_language to update_language but it was still referred to in some html templates. Without this change, any instance with multiple languages configured via Darklang will raise error in the dashboard.

Useful information to include:

  • Which edX user roles will this change impact: "Learner", "Course Author", "Developer", and "Operator".

Testing instructions

  • In master branch
  • Enable multiple languages via darklang. Tutorial link
  • Logout and try to visit home url: http://localhost:18000/dashboard in case of devstack.
  • It will raise 500 error.
  • Checkout this PR and it should be fixed.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 16, 2023
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@navinkarkera

navinkarkera commented Nov 16, 2023

Copy link
Copy Markdown
Contributor Author

@Agrendalath This is a bug fix, would you be able to merge this as CC.

@open-craft-grove

Copy link
Copy Markdown

Sandbox deploy request received. Deployment will start soon.

@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment started.

@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment successful.

Sandbox LMS is available at pr-33729-139931.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-33729-139931.staging.do.opencraft.hosting

@Agrendalath Agrendalath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: anonymous users can now view the pages when the language picker is enabled
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a

@Agrendalath

Copy link
Copy Markdown
Member

@navinkarkera, I tested this and left my +1. Would you be able to handle the merging part?

@navinkarkera

Copy link
Copy Markdown
Contributor Author

@Agrendalath Sure, thanks!

The url was renamed from session_language to update_language but it was still referred to in some html templates
@open-craft-grove

Copy link
Copy Markdown

Sandbox update request received. Deployment will start soon.

@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment started.

@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment successful.

Sandbox LMS is available at pr-33729-139931.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-33729-139931.staging.do.opencraft.hosting

@navinkarkera
navinkarkera merged commit e9ca49d into openedx:master Nov 23, 2023
@navinkarkera
navinkarkera deleted the navin/fix-url-rename branch November 23, 2023 16:36
@openedx-webhooks

Copy link
Copy Markdown

@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@open-craft-grove

Copy link
Copy Markdown

Sandbox update request received. Deployment will start soon.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants