fix: session_language url renamed to update_language - #33729
Conversation
|
Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
@Agrendalath This is a bug fix, would you be able to merge this as CC. |
|
Sandbox deploy request received. Deployment will start soon. |
|
Sandbox deployment started. |
|
Sandbox deployment successful. Sandbox LMS is available at pr-33729-139931.staging.do.opencraft.hosting |
Agrendalath
left a comment
There was a problem hiding this comment.
👍
- I tested this: anonymous users can now view the pages when the language picker is enabled
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
|
@navinkarkera, I tested this and left my +1. Would you be able to handle the merging part? |
|
@Agrendalath Sure, thanks! |
The url was renamed from session_language to update_language but it was still referred to in some html templates
34d1089 to
1d6ab04
Compare
|
Sandbox update request received. Deployment will start soon. |
|
Sandbox deployment started. |
|
Sandbox deployment successful. Sandbox LMS is available at pr-33729-139931.staging.do.opencraft.hosting |
|
@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
Sandbox update request received. Deployment will start soon. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
The url was renamed from session_language to update_language but it was still referred to in some html templates. Without this change, any instance with multiple languages configured via Darklang will raise error in the dashboard.
Useful information to include:
Testing instructions
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.