Skip to content

[BACKPORT] Fix reverse error for renamed session_language URL - #34418

Merged
navinkarkera merged 1 commit into
openedx:open-release/quince.masterfrom
raccoongang:quince/fix-lang-url
Apr 2, 2024
Merged

[BACKPORT] Fix reverse error for renamed session_language URL#34418
navinkarkera merged 1 commit into
openedx:open-release/quince.masterfrom
raccoongang:quince/fix-lang-url

Conversation

@dyudyunov

Copy link
Copy Markdown
Contributor

This is a backport from #33729

Description

The URL was renamed, but some templates use the old name.

Steps to reproduce

  1. Add several language codes to the Dark Lang Config using the LMS admin (e.g. en, uk)
  2. Log out

Actual result

NoReverseMatch error

image

The url was renamed from session_language to update_language but it was still referred to in some html templates
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 25, 2024
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @dyudyunov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Mar 25, 2024
@mphilbrick211

Copy link
Copy Markdown

Hi @navinkarkera! Would you be able to merge this backport since you merged the master? If not, let me know.

@navinkarkera navinkarkera left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dyudyunov Thanks! Looks good.

@navinkarkera
navinkarkera merged commit 0906265 into openedx:open-release/quince.master Apr 2, 2024
@openedx-webhooks

Copy link
Copy Markdown

@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@dyudyunov
dyudyunov deleted the quince/fix-lang-url branch April 3, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants