Upgrade pymongo - #34675
Conversation
343bc83 to
bb7d0f2
Compare
b0683c5 to
4139dea
Compare
424c152 to
42fd48e
Compare
39a0ef6 to
dd4fca6
Compare
a2a594d to
a0c6c6d
Compare
a1305b0 to
849d7c0
Compare
feanil
left a comment
feanil
left a comment
There was a problem hiding this comment.
A couple of questions but this generally makes sense to me.
| @@ -1,3 +0,0 @@ | |||
| # We want to ignore files in this directory which we do in the | |||
There was a problem hiding this comment.
Why did you remove this message? It seems useful.
There was a problem hiding this comment.
This change is temporary to make sandbox builds successful.
Will be reverted before this pr is merged.
| thumbnail_location[4] | ||
| ) | ||
|
|
||
| # md5 = getattr(fp, 'md5', None) |
There was a problem hiding this comment.
Are these comments still needed?
There was a problem hiding this comment.
Not needed. Removed.
1a06f6a to
b840069
Compare
feanil
left a comment
feanil
left a comment
There was a problem hiding this comment.
One small question, but the approach generally seems good, There are a lot of new very small functions check_connection do_connection, etc. They made it harder for me to read through what was happening, was there a reason for making these new functions?
| camel-converter[pydantic]==3.1.2 | ||
| # via meilisearch | ||
| celery==5.4.0 | ||
| celery==5.3.6 |
There was a problem hiding this comment.
Why is celery being downgraded?
There was a problem hiding this comment.
@mumarkhan999 still waiting for an answer to why this happened.
These functions are needed to manage the availability of MongoDB connections. In pymongo versions >4.x.xx the reconnection functionality has been removed. |
feanil
left a comment
feanil
left a comment
There was a problem hiding this comment.
Generally looks good to me and makes sense. I just have one last question about the downgrade of the celery dependency.
| camel-converter[pydantic]==3.1.2 | ||
| # via meilisearch | ||
| celery==5.4.0 | ||
| celery==5.3.6 |
There was a problem hiding this comment.
@mumarkhan999 still waiting for an answer to why this happened.
7e42749 to
9e6af2d
Compare
feanil
left a comment
feanil
left a comment
There was a problem hiding this comment.
Some small nits and suggestion but I think once those are addressed this can be merged. I don't need to do another round of review unless there are significant changes.
There was a problem hiding this comment.
Reminder to revert this change before merging.
| @@ -34,7 +34,10 @@ django-simple-history==3.4.0 | |||
|
|
|||
| # constrained in opaque_keys. migration guide here: https://pymongo.readthedocs.io/en/4.0/migrate-to-pymongo4.html | |||
There was a problem hiding this comment.
Does this comment need to be updated now?
| pymongo<4.0.0 | ||
| pymongo<4.4.1 | ||
|
|
||
| # To override the constraint of edx-lint |
There was a problem hiding this comment.
| # To override the constraint of edx-lint | |
| # To override the constraint of edx-lint | |
| # This can be removed once https://github.com/openedx/edx-platform/issues/34586 is resolved | |
| # and the upstream constraint in edx-lint has been removed. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
3 participants
Issue Link
Description
Related PRs