Skip to content

fix: failing Docs Builds - #35846

Merged
irtazaakram merged 1 commit into
openedx:masterfrom
irtazaakram:fix35807
Nov 18, 2024
Merged

fix: failing Docs Builds#35846
irtazaakram merged 1 commit into
openedx:masterfrom
irtazaakram:fix35807

Conversation

@irtazaakram

@irtazaakram irtazaakram commented Nov 14, 2024

Copy link
Copy Markdown
Member

@irtazaakram
irtazaakram marked this pull request as ready for review November 15, 2024 06:58
@irtazaakram
irtazaakram requested a review from a team as a code owner November 15, 2024 06:58
irtazaakram
irtazaakram commented Nov 15, 2024
View reviewed changes
Comment thread openedx/core/djangoapps/user_api/accounts/utils.py
Comment on lines +54 to +58
Returns:
- An empty string if `new_social_link` is empty.
- A formatted URL if `new_social_link` is a username.
- Returns `new_social_link` if it is a valid URL.
- None for unparseable inputs.

@irtazaakram irtazaakram Nov 15, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes: ValueError: 'platform_name_base' does not appear to be an IPv4 or IPv6 address

irtazaakram
irtazaakram commented Nov 15, 2024
View reviewed changes
Comment thread docs/conf.py
]

autoapi_type = 'python'
autoapi_dirs = ['../lms', '../openedx']

@irtazaakram irtazaakram Nov 15, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inline with settings here: https://github.com/openedx/edx-platform/blob/1b405afe2d9d782b30c7edd525e3d4f3ff59c723/docs/conf.py#L290-L299

@irtazaakram
irtazaakram requested a review from feanil November 15, 2024 10:44
@feanil

feanil commented Nov 15, 2024

Copy link
Copy Markdown
Contributor

@irtazaakram I'm still seeing the following error when I run make docs

Extension error (autoapi.extension):
Handler <function run_autoapi at 0x7a41042537e0> for event 'builder-inited' threw an exception (exception: 'list' object has no attribute 'get_children')
make: *** [Makefile:22: html] Error 2

irtazaakram
irtazaakram commented Nov 15, 2024
View reviewed changes
Comment thread openedx/core/lib/xblock_serializer/data.py Outdated
@irtazaakram
irtazaakram marked this pull request as draft November 15, 2024 18:19
irtazaakram
irtazaakram commented Nov 15, 2024
View reviewed changes
Comment thread docs/conf.py
'*/tests/*',
'*.pyc',
'__init__.py',
'**/xblock_serializer/data.py',

@irtazaakram irtazaakram Nov 15, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary workaround as It requires too many changes here to be able to build using autoapi.

@irtazaakram
irtazaakram marked this pull request as ready for review November 15, 2024 18:37
@irtazaakram
irtazaakram merged commit 68a626a into openedx:master Nov 18, 2024
@irtazaakram
irtazaakram deleted the fix35807 branch November 18, 2024 06:30
@edx-pipeline-bot

edx-pipeline-bot commented Nov 18, 2024

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

edx-pipeline-bot commented Nov 18, 2024

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot

edx-pipeline-bot commented Nov 18, 2024

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@farhaanbukhsh farhaanbukhsh mentioned this pull request Nov 19, 2024
Closed
11 tasks
@mariajgrimaldi mariajgrimaldi mentioned this pull request Nov 26, 2024
Merged
mariajgrimaldi pushed a commit that referenced this pull request Dec 5, 2024
@irtazaakram @mariajgrimaldi
fix: replace autodoc with autoapi (#35846)
1115edb
This was referenced Dec 6, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deborahgu deborahgu deborahgu approved these changes
@feanil feanil feanil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix Failing edx-platform Docs Builds

4 participants

@irtazaakram @feanil @edx-pipeline-bot @deborahgu