-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix: failing Docs Builds #35846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: failing Docs Builds #35846
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,7 +55,6 @@ | |
| # extensions coming with Sphinx (named 'sphinx.ext.*') or your custom | ||
| # ones. | ||
| extensions = [ | ||
| 'sphinx.ext.autodoc', | ||
| 'sphinx.ext.coverage', | ||
| 'sphinx.ext.doctest', | ||
| 'sphinx.ext.graphviz', | ||
|
|
@@ -68,6 +67,18 @@ | |
| 'sphinx_design', | ||
| 'code_annotations.contrib.sphinx.extensions.featuretoggles', | ||
| 'code_annotations.contrib.sphinx.extensions.settings', | ||
| 'autoapi.extension', | ||
| ] | ||
|
|
||
| autoapi_type = 'python' | ||
| autoapi_dirs = ['../lms', '../openedx'] | ||
|
|
||
| autoapi_ignore = [ | ||
| '*/migrations/*', | ||
| '*/tests/*', | ||
| '*.pyc', | ||
| '__init__.py', | ||
| '**/xblock_serializer/data.py', | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Temporary workaround as It requires too many changes here to be able to build using |
||
| ] | ||
|
|
||
| # Rediraffe related settings. | ||
|
|
@@ -277,13 +288,6 @@ | |
| 'django': ('https://docs.djangoproject.com/en/1.11/', 'https://docs.djangoproject.com/en/1.11/_objects/'), | ||
| } | ||
|
|
||
| # Mock out these external modules during code import to avoid errors | ||
| autodoc_mock_imports = [ | ||
| 'MySQLdb', | ||
| 'django_mysql', | ||
| 'pymongo', | ||
| ] | ||
|
|
||
| # Start building a map of the directories relative to the repository root to | ||
| # run sphinx-apidoc against and the directories under "docs" in which to store | ||
| # the generated *.rst files | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,11 +51,11 @@ def format_social_link(platform_name, new_social_link): | |
| """ | ||
| Given a user's social link, returns a safe absolute url for the social link. | ||
|
|
||
| Returns the following based on the provided new_social_link: | ||
| 1) Given an empty string, returns '' | ||
| 1) Given a valid username, return 'https://www.[platform_name_base][username]' | ||
| 2) Given a valid URL, return 'https://www.[platform_name_base][username]' | ||
| 3) Given anything unparseable, returns None | ||
| Returns: | ||
| - An empty string if `new_social_link` is empty. | ||
| - A formatted URL if `new_social_link` is a username. | ||
| - Returns `new_social_link` if it is a valid URL. | ||
| - None for unparseable inputs. | ||
|
Comment on lines
+54
to
+58
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixes: |
||
| """ | ||
| # Blank social links should return '' or None as was passed in. | ||
| if not new_social_link: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is inline with settings here: https://github.com/openedx/edx-platform/blob/1b405afe2d9d782b30c7edd525e3d4f3ff59c723/docs/conf.py#L290-L299