fix: sidebar completion for completable XBlocks with children

[Agrendalath]

Description

It is possible to create a completable XBlock with children. An example is the Library Content Block with the MARK_LIBRARY_CONTENT_BLOCK_COMPLETE_ON_VIEW feature toggle. The sidebar should use the same mechanism as the BlockCompletionTransformer and the edx-completion library. It means that we should treat:

1. An aggregator XBlock as completed only when all its children are completed.
2. A completable XBlock as completed when it is directly marked as completed (without checking the completion of its children).

Testing instructions

1. Do not check out the branch from this PR.
2. Set settings.FEATURES['MARK_LIBRARY_CONTENT_BLOCK_COMPLETE_ON_VIEW'] = True.
3. Create a new library with a Problem XBlock.
4. Create a new subsection with two units - the first with this new library and the second with any other XBlock. Publish these blocks.
5. Visit the Library Content Block in the LMS. Do not submit the problem - only wait a few seconds for the publish_completion request to be sent (you can check it, e.g., with the Network tab).
6. Click the button to navigate to the second unit (without refreshing the page). This will trigger the get_completion request, which retrieves the completion data from the completion service (from the edx-completion).
7. Refresh the page. See that the completion checkmark for the first unit is now gone.
8. Check out the branch from this PR.
9. Refresh the page. See that the completion checkmark for the first unit is now displayed correctly.

Deadline

"None"

Private-ref: BB-8469 (temporary)

[openedx-webhooks]

Thanks for the pull request, @Agrendalath!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[mphilbrick211]

@farhaanbukhsh friendly ping on this!

[sarina]

This has the dubious distinction of being one of our top 10 oldest PRs. @Agrendalath @farhaanbukhsh are you planning to move forward with this PR, or should it be closed?

[Agrendalath]

@sarina, even though this (and PRs like #36135 or #36136) are fixes, they were opened on behalf of one of our clients, so we cannot use the CC budget to review them. We will review and merge these PRs in July (or August, in case there is not enough budget in July).

cc: @farhaanbukhsh

[farhaanbukhsh]

@Agrendalath can you rebase this branch please :)

[Agrendalath]

@farhaanbukhsh, sure - done.

[farhaanbukhsh]

👍

• ✅ I tested this on master Tutor devstack and it helps to fixs the completable XBlock for Library
• ✅ I read through the code
• ❌ I checked for accessibility issues
• ❌ Includes documentation

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX production environment.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX production environment.