fix: ensure TagCountFactory is bundled in production - #36136
Conversation
Remove the `static:webpack` directive and use `add_webpack_js_to_fragment` to properly include TagCountFactory in production. The previous solution did not correctly bundle this factory, causing the `ReferenceError: TagCountFactory is not defined` JS error in the Studio preview.
|
Thanks for the pull request, @Agrendalath! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
@Agrendalath can you please add testing instruction to reproduce this issue? |
|
@farhaanbukhsh, it should be possible to reproduce this by skipping the first step from the "Testing instructions" section of this PR's description. |
|
@Agrendalath I am not able to find out the error in the console. |
|
@farhaanbukhsh, I see. I will check this again next week. |
|
@farhaanbukhsh, I cannot reproduce this error anymore. Let's close this PR. |
This removes the
static:webpackdirective and usesadd_webpack_js_to_fragmentto properly include TagCountFactory in production. The previous solution (#34059) did not correctly bundle this factory, causing theReferenceError: TagCountFactory is not definedJS error in the Studio preview.Testing instructions
tutor dev exec cms npm run webpack.ReferenceError: TagCountFactory is not definederror in the console logs.Private-ref: BB-9480