feat!: Legacy account, profile, order history removal - #36219
Merged
deborahgu merged 4 commits intoFeb 10, 2025
Merged
Conversation
**DRAFT** This work is in progress, tests are failing, in no way is this ready to go. FIXES: APER-3884
This removes the legacy account and profile applications, and the order history page. This is primarily a reapplication of #31893, which was rolled back due to prior blockers. FIXES: APER-3884 FIXES: openedx/public-engineering#71 --------- Co-authored-by: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com>
…ile-legacy-django-apps
it looks like prior attempts to reformat the files moved pylint directives to the wrong lines.
deborahgu
commented
Feb 4, 2025
| ALLOWED_HOSTS = [ | ||
| '*' | ||
| ] | ||
| ALLOWED_HOSTS = ["*"] |
Member
Author
There was a problem hiding this comment.
Aargh, I didn't mean to let my IDE reformat this file to our current standards. I mean, it's not wrong, but it makes life harder for the reviewers. Sorry. 😬 I think it's just this file, though.
justinhynes
reviewed
Feb 10, 2025
| # .. toggle_target_removal_date: 2020-12-31 | ||
| # .. toggle_warning: Also set settings.PROFILE_MICROFRONTEND_URL and site's ENABLE_PROFILE_MICROFRONTEND. | ||
| # .. toggle_tickets: DEPR-17 | ||
| REDIRECT_TO_PROFILE_MICROFRONTEND = WaffleFlag(f'{WAFFLE_FLAG_NAMESPACE}.redirect_to_microfrontend', __name__) |
Contributor
There was a problem hiding this comment.
Do we need to add any additional internal tickets to clean up the config for this flag in the LMS?
edit: (and the other flags removed in this PR)
justinhynes
reviewed
Feb 10, 2025
| ############## Settings for Microfrontends ######################### | ||
| LEARNING_MICROFRONTEND_URL = 'http://localhost:2000' | ||
| ACCOUNT_MICROFRONTEND_URL = 'http://localhost:1997' | ||
| PROFILE_MICROFRONTEND_URL = 'http://localhost:1995' |
Contributor
There was a problem hiding this comment.
2U specific -- I think we want to add this change to https://github.com/edx/devstack/blob/master/py_configuration_files/lms.py
Member
Author
There was a problem hiding this comment.
I will make that PR, thanks. I knew there was a reason I asked you to be the reviewer 😆
justinhynes
approved these changes
Feb 10, 2025
deborahgu
deleted the
dkaplan1/APER-3884_remove-account-and-profile-legacy-django-apps
branch
February 10, 2025 19:39
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Member
|
Wow. Thank you so much for doing this. 🔥🔥🔥 |
This was referenced Feb 14, 2025
jciasenza
pushed a commit
to jciasenza/edx-platform
that referenced
this pull request
Feb 25, 2025
* feat!: Legacy account, profile, order history removal This removes the legacy account and profile applications, and the order history page. This is primarily a reapplication of openedx#31893, which was rolled back due to prior blockers. FIXES: APER-3884 FIXES: openedx/public-engineering#71 Co-authored-by: Muhammad Abdullah Waheed <42172960+abdullahwaheed@users.noreply.github.com> Co-authored-by: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com>
tonybusa
pushed a commit
to tonybusa/edx-platform
that referenced
this pull request
Apr 23, 2025
* feat!: Legacy account, profile, order history removal This removes the legacy account and profile applications, and the order history page. This is primarily a reapplication of openedx#31893, which was rolled back due to prior blockers. FIXES: APER-3884 FIXES: openedx/public-engineering#71 Co-authored-by: Muhammad Abdullah Waheed <42172960+abdullahwaheed@users.noreply.github.com> Co-authored-by: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com>
UsamaSadiq
pushed a commit
that referenced
this pull request
May 14, 2025
* feat!: Legacy account, profile, order history removal This removes the legacy account and profile applications, and the order history page. This is primarily a reapplication of #31893, which was rolled back due to prior blockers. FIXES: APER-3884 FIXES: openedx/public-engineering#71 Co-authored-by: Muhammad Abdullah Waheed <42172960+abdullahwaheed@users.noreply.github.com> Co-authored-by: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the legacy account and profile applications, and the order history page. This is primarily a reapplication of #31893, which was rolled back due to prior blockers in an external repository, now resolved.
FIXES: APER-3884
FIXES: openedx/public-engineering#71
Co-authored-by: Bilal Qamar 59555732+BilalQamar95@users.noreply.github.com
Co-authored-by: Muhammad Abdullah Waheed 42172960+abdullahwaheed@users.noreply.github.com