Skip to content

fix!: Remove discussions.pages_and_resources waffle - #37667

Draft
kdmccormick wants to merge 1 commit into
openedx:masterfrom
kdmccormick:kdmccormick/pages-and-resources
Draft

fix!: Remove discussions.pages_and_resources waffle#37667
kdmccormick wants to merge 1 commit into
openedx:masterfrom
kdmccormick:kdmccormick/pages-and-resources

Conversation

@kdmccormick

Copy link
Copy Markdown
Member

Description

The waffle flag discussions.pages_and_resources_mfe was intended to gate the Studio MFE Pages and Resources view, but it has not actually done that for some time. The MFE Pages and Resources view has been shown to all users regardless of its value, possibly as far back as Quince.

However, this flag had an undocumented side-effect, noted below...

BREAKING CHANGE: Previously, the legacy discussions experience could be incidentally enabled simply by NOT enabling discussions.pages_and_resources_mfe. This will no longer work. Instead, operators who wish to enable the legacy discussions experience will need to enable
discussions.override_discussion_legacy_settings.

Part of: #36275

Testing instructions

TBC

Deadline

None

The waffle flag `discussions.pages_and_resources_mfe` was intended to
gate the Studio MFE Pages and Resources view, but it has not actually
done that for some time. The MFE Pages and Resources view has been shown
to all users regardless of its value, possibly as far back as Quince.

However, this flag had an undocumented side-effect, noted
below...

BREAKING CHANGE: Previously, the legacy discussions experience
could be incidentally enabled simply by NOT enabling
`discussions.pages_and_resources_mfe`. This will no longer work.
Instead, operators who wish to enable the legacy discussions
experience will need to enable
`discussions.override_discussion_legacy_settings`.

Related to: openedx#36275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant