Fix: inadvertent scroll when loading the instructor's extensions tab - #4905
Merged
Conversation
(The div with id "view-extensions" conflicts with the tab JS which sets location.hash to "view-x" in order to track the current tab)
Contributor
|
@carsongee would you mind taking a look at this small PR when you get a chance? |
Contributor
|
👍 will merge once tests pass and Carson takes a quick look. |
Contributor
|
The view granted extensions portions seems to be broken here. I get a 400 and nothing is displayed. That isn't the case in master |
Contributor
|
@carsongee do you have a screenshot? Everything worked fine for me... |
Contributor
Contributor
|
and seeing: in the js console. |
Contributor
|
d'oh, wasn't paying close enough attention and missed the coffee file and didn't rebuild assets after switching branches. Sorry about that. 👍 |
Contributor
|
:) thanks for debugging! |
sarina
added a commit
that referenced
this pull request
Aug 20, 2014
Fix: inadvertent scroll when loading the instructor's extensions tab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This minor commit fixes an annoying UI bug with the individual due date extensions, mentioned to me by @sarina in #4868. Whenever an instructor clicked on the "Extensions" tab, the browser would scroll down. This was due to a div having id "view-extensions", conflicting with the tabs script which sets location.hash to "view-[current tab name]" in order to track the current tab.
This was done for OpenCraft ( cc @antoviaque ) and falls under their organization contributor agreement.