Skip to content

Fix: inadvertent scroll when loading the instructor's extensions tab #4905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarina merged 1 commit into from
Aug 20, 2014
Merged

Fix: inadvertent scroll when loading the instructor's extensions tab #4905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lms/static/coffee/src/instructor_dashboard/extensions.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,30 +70,30 @@ class Extensions
@clear_display()
@$grid_table.text 'Loading...'

@$url_input = @$section.find("#view-extensions select[name='url']")
@$url_input = @$section.find("#view-granted-extensions select[name='url']")
url = @$show_unit_extensions.data 'endpoint'
send_data =
url: @$url_input.val()
$.ajax
dataType: 'json'
url: url
data: send_data
error: (xhr) => @fail_with_error "view-extensions", "Error getting due dates", xhr
error: (xhr) => @fail_with_error "view-granted-extensions", "Error getting due dates", xhr
success: (data) => @display_grid data

@$show_student_extensions.click =>
@clear_display()
@$grid_table.text 'Loading...'

url = @$show_student_extensions.data 'endpoint'
@$student_input = @$section.find("#view-extensions input[name='student']")
@$student_input = @$section.find("#view-granted-extensions input[name='student']")
send_data =
student: @$student_input.val()
$.ajax
dataType: 'json'
url: url
data: send_data
error: (xhr) => @fail_with_error "view-extensions", "Error getting due dates", xhr
error: (xhr) => @fail_with_error "view-granted-extensions", "Error getting due dates", xhr
success: (data) => @display_grid data

# handler for when the section title is clicked.
Expand Down
2 changes: 1 addition & 1 deletion lms/templates/instructor/instructor_dashboard_2/extensions.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ <h2>${_("Individual due date extensions")}</h2>
</p>
</div>
<hr/>
<div id="view-extensions">
<div id="view-granted-extensions">
<h2>${_("Viewing granted extensions")}</h2>
<p>
${_("Here you can see what extensions have been granted on particular "
Expand Down