Rename CourseLocator.revision to branch - #528
Merged
Merged
Conversation
and all related vars and methods.
Contributor
|
Looking at the diff-coverage report (http://jenkins.edx.org:8080/job/edx-pull-request-tests/1961/Diff_Coverage_Report), there are a bunch of lines in test_locators that changed that aren't covered. It looks like that's because we're skipping a bunch of tests. Do those tests need to be skipped? And, if so, can you add the reason why they are being skipped to the SkipTest exception? |
Contributor
Author
|
argh! Steve Strassman marked them skip and I failed to notice. :-( Looks like I won't finish the translator today. |
which a previous refactoring had replaced. Coverage of locator.py is 100%
Contributor
Author
|
@cpennington it looks like steve had completely replaced the tests but not removed the old ones. |
Contributor
|
👍 |
dmitchell
added a commit
that referenced
this pull request
Jul 31, 2013
Rename CourseLocator.revision to branch
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
adding maintenance static data
Kelketek
referenced
this pull request
in open-craft/openedx-platform
Sep 17, 2015
Add indexes to 'modified' and 'completions' on StudentProgress model.
caesar2164
pushed a commit
to caesar2164/edx-platform
that referenced
this pull request
Jan 24, 2017
* cme/6: Supporting custom message on Progress page
yoann-mroz
pushed a commit
to weuplearning/edx-platform
that referenced
this pull request
Nov 30, 2020
PR openedx#505 mistakenly omitted the microfrontend services from the new `DEFAULT_SERVICES` list, which determines what is brought up upon `make dev.up`.
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
…gation items. (openedx#528) Co-authored-by: SaadYousaf <saadyousaf@A006-00314.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and all related vars and methods.
Wanted to better convey the idea of not just a variant but an evolving variant. Only affects split mongo.
@cdodge @cpennington pls review