Replace "edX Studio" with "{studio_name}" - #6309
Merged
Merged
Conversation
singingwolfboy
force-pushed
the
db/edx-studio-as-format-string
branch
3 times, most recently
from
December 19, 2014 18:48
fc01613 to
2270dc5
Compare
For theming and internationalization
singingwolfboy
force-pushed
the
db/edx-studio-as-format-string
branch
from
December 19, 2014 18:58
2270dc5 to
7366d2b
Compare
STUDIO_NAME = "edX Studio" STUDIO_SHORT_NAME = "Studio"
Contributor
There was a problem hiding this comment.
# If you change this in another settings file you might have to change STUDIO_NAME also for STUDIO_SHORT_NAME.
singingwolfboy
force-pushed
the
db/edx-studio-as-format-string
branch
from
December 23, 2014 18:32
1b0d2d7 to
320941e
Compare
Contributor
There was a problem hiding this comment.
I don't like the open-span and close-span being treated differently.
Contributor
Author
There was a problem hiding this comment.
I did it like this so that the translators didn't have to think about HTML. Can you suggest another way to do this that still makes thing easier for the translators?
Contributor
|
👍 |
singingwolfboy
added a commit
that referenced
this pull request
Dec 23, 2014
Replace "edX Studio" with "{studio_name}"
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For OPEN-423. This probably needs further discussion and review -- do we want to have a
{studio_name}for "edX Studio" and a{studio_short_name}for "Studio"? Seems like several places use "Studio" rather than "edX Studio" rather intentionally.