update copyright dates - #6501
Conversation
|
Oh nevermind, @sarina beat me to this (was working off an old branch) https://github.com/edx/edx-platform/pull/6458 Studio's footer still needs updating--i'll update this PR to just change studio's footer |
|
@adampalay yep. You should cancel your build, too, to not tie up Jenkins. |
9f5f0d2 to
41f2c73
Compare
|
@sarina and @singingwolfboy , ok, ready for review |
|
LGTM. Actually though since you're in here, could you change the string in https://github.com/edx/edx-platform/blob/master/lms/templates/footer-edx-new.html#L35 to match the string in https://github.com/edx/edx-platform/blob/master/lms/templates/footer.html#L55 just so we aren't pushing 2 different translation strings to transifex? I don't know how I missed that. |
There was a problem hiding this comment.
Actually - can you make this use {platform_name}, too? We're trying to get all branding out of Studio as well as LMS. This should have been done in #6309 but was obviously missed.
|
@adampalay we want this particular copyright to be platform name. There's an upcoming OPen Source task for next week to add in a specific copyright notice to the LMS and Studio regarding the use of the edX logo and branding, that will hardcode in an edX copyright on the things we would copyright. But we don't own the copyright on another site. |
41f2c73 to
8fa00ea
Compare
|
@sarina , cool? |
|
👍 verified in devstack |
|
👍 |
3 participants
@singingwolfboy and @sarina
It's no longer 2014 :) 🎆