Skip to content

WIP: Correct Pylint violations - #7008

Closed
stvstnfrd wants to merge 31 commits into
openedx:masterfrom
stvstnfrd:quality/pylint
Closed

WIP: Correct Pylint violations#7008
stvstnfrd wants to merge 31 commits into
openedx:masterfrom
stvstnfrd:quality/pylint

Conversation

@stvstnfrd

Copy link
Copy Markdown
Contributor

No description provided.

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @stvstnfrd! I've created OSPR-410 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ('this must be merged by XX date', and why that is)
  • partner information ('this is a course on edx.org')
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the Github pull request interface. As a reminder, our process documentation is here.

@sarina

sarina commented Feb 18, 2015

Copy link
Copy Markdown
Contributor

oof! lots of test failures. Already this has merge conflicts, and I am going to assume that we should merge in #6998 before continuing, no?

It might be easier to split up these violations into separate PRs, especially given the wealth of test failures.

@openedx-webhooks openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed community manager review labels Feb 18, 2015
@sarina

sarina commented Feb 18, 2015

Copy link
Copy Markdown
Contributor

for some reason, Jenkins is being a butt. This was your most recent build.

@stvstnfrd

Copy link
Copy Markdown
Contributor Author

Yes, we can merge #6998 before this.

The funny thing is that I already pulled much out of this PR, but you're right; it'll probably make sense to split this out further.

I'll rebase, take and look at test failures, and probably start splitting out some of these commits. I'll ping you again when this is ready.

@sarina

sarina commented Mar 3, 2015

Copy link
Copy Markdown
Contributor

This is getting supplemented by newer, smaller PRs so I'm going to close this one.

@sarina sarina closed this Mar 3, 2015
@stvstnfrd
stvstnfrd deleted the quality/pylint branch February 17, 2018 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants