Fix Pylint violations (medium)

[stvstnfrd]

This is a replacement subset of #7008.

Review commit-by-commit for additional clarity.

[openedx-webhooks]

Thanks for the pull request, @stvstnfrd! I've created OSPR-421 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

• supporting documentation
• edx-code email threads
• timeline information ('this must be merged by XX date', and why that is)
• partner information ('this is a course on edx.org')
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the Github pull request interface. As a reminder, our process documentation is here.

[singingwolfboy]

Do you know why this code is Exception.__str__(self, *args, **kwargs) instead of just self? The string formatting should automatically coerce the self argument to a string.

If you don't want to make this change, that's fine with me -- I'm in favor of keeping this pull request small and focused as much as possible. This just caught my eye, and I was confused.

[stvstnfrd]

Yeah, I'm not sure either, so I think I'll opt to pass for now :)

[singingwolfboy]

Looks like there was a problem with this Jenkins build. Jenkins, test this please.

[singingwolfboy]

Looks like we're getting a bunch of import errors when running the tests. @stvstnfrd, can you look into this?

[stvstnfrd]

Finally got a green build going; ready for rereview @singingwolfboy

[sarina]

@stvstnfrd I'll finsih up the review here.

Can you please rebase to pick up the fixes to Jenkins reporting?

[stvstnfrd]

@sarina I'm not seeing a Jenkins error (rebased over the weekend).

[sarina]

Added a few nits. Good to merge once those are addressed (or argued against) and the PR is rebased.

[sarina]

@stvstnfrd the commit that Ben reverted this morning because coverage wasn't properly reported in common/ after the stuff I merged Friday

[sarina]

#7187 fyi

[sarina]

Needs a rebase, then it's good to merge.

[stvstnfrd]

@sarina Rebased, clean build, dropped Pylint threshold to 5800 (5739 violations reported).

[sarina]

nice!! :D

[stvstnfrd]

Thanks @sarina !