Mjevtic/sol 536 implement experiment aware content search - #8084
Closed
marjev wants to merge 87 commits into
Closed
Conversation
Remove outdated comment referencing IE9 rule limit
LMS: removing redundant Sass base/base partial call in build compile
Tags Tab in Student Notes
Moving no-outline use to be more global
* since IE9 and below are formally not supported any longer * since most of the CSS rules are for UI that has been removed or that is supported by modern browsers
Add flaky test decorator (TNL-2199)
Move xmodule_modifiers.py to openedx/xblock
Update ecommerce-api-client and add regression test for XCOM-1606
Also, I replaced a number of tearDown methods with addCleanup instead. And also remove some unneeded patch.stopall() calls.
* to reflect support for IE10 and above * to only flag IE9 (for emergency's sake) with specific html class attrs * to remove HTML5 shiv that's not needed for IE10 and above
* to reflect support for IE10 and above * to only flag IE9 (for emergency's sake) with specific html class attrs
TNL-2047
Fixing the pencil icon issue. TNL-2047
Adding the pyuca to support sorting in differnet languages. TNL-2047
There was a problem hiding this comment.
With the addition on the get_item_location method here, seems like we no longer really have a need for item_location variable
|
Do we need to test content that is cohorted that has split-tests? (@pbaruah) |
…it in a feature flag and updated previously named footer-edx-new.html to footer-edx-v2.html to better track/name updates to the footer going forward. ECOM-1547 removed data-updated attributes from body ECOM-1548 added JS file that inits analytics event listener and makes ajax call to API to get footer and HTML and add it to the DOM ECOM-1547 code review cleanup ECOM-1547 rebase and Sass appraoch update after @talbs the IE9 killer slayed the mighty beast. ECOM-1547 updated file names and added comments in light of @talbs review of PR ECOM-1547 update to social media link styles and nav link order ECOM-1547 updated SOCIAL_MEDIA_FOOTER_NAMES if ENABLE_FOOTER_V3 is true ECOM-1547 added translations to screenreader text ECOM-1547 fixed test and renamed files in line with @talbs's pending PR ECOM-1547 cleaned up file naming
The checks are now within the Python API instead of the DRF view. This will be necessary for certain operations (like fetching/editing threads) because the relevant course cannot be known until the thread is fetched from the comments service. This commit updates the existing endpoints to fit that pattern.
This will make it easier to add the creation and update interfaces.
But mark `data` as non-editable metadata, so that it doesn't appear
This allows course authors to choose between two difference licenses for their course content: All Rights Reserved, or Creative Commons. In the backend, XBlocks that wish to allow custom licenses need only inherit from LicenseMixin, which adds a `license` field as a string. License information is displayed in the Studio editor view, and just below the rendered XBlock in the LMS. In addition, if the course block itself has a custom license set, this license will display just below the main body of the page on courseware pages. This entire feature is gated behind the LICENSING feature flag.
Use native checkboxes for courseware license options In Studio settings editor for video module, don't show license if feature-flagged off Don't let Scope.contents fields leak to Studio editor JS gettext() must all be on the same line for i18n Add docstrings for bok-choy tests Remove LicenseMixin from HTMLDescriptor Responding to UX review feedback Add aria-pressed attribute Use https links instead of protocol-relative links for links to creativecommons.org Remove license from course outline page in Studio
Clicking on conflicting option box unchecks all conflicts LMS: Clicking license text should bring to new window updated styles to reflect html reuse inside of xblock edit modal area. Add ARIA attributes to license for a11y Gracefully handle re-selecting of selected license
Alasdair/ecom 1547 footer 2015
clean up all-tests.sh script
Skip flaky test. SOL-618.
Allow custom licensing for course content
…efactor Refactor Discussion API thread list
BUG - remove username label from dashboard sidebar #UX-2153
Remove unused css
marjev
force-pushed
the
mjevtic/SOL-536-implement-experiment-aware-content-search
branch
from
May 19, 2015 10:42
68875a3 to
3835092
Compare
Contributor
Author
|
Closing this PR because #8043 was merged. I will open a new PR with master as a base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #8069