[WIP] Mjevtic/sol 536 implement experiment aware content search

[marjev]

@martynjames

This PR replaces #8084

Latest commit addresses the comments you left on the #8084

[openedx-webhooks]

Thanks for the pull request, @marjev! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request.

To automatically create an OSPR issue for this pull request, just visit this link: http://openedx-webhooks.herokuapp.com/github/process_pr?number=8100&repo=edx%2Fedx-platform

[marjev]

@martynjames Can you put some light on why this is necessary here? With this line in __init__.py, I can't import the constant SPLIT_TEST_COMPONENT_TYPE.

This is just a temporary solution. I would like to get your opinion on the matter since I saw that you've added this as a part of #7313.

[dino-cikatic]

Is this really the only way to get group_id? Splitting display name strings by space?

[martynjames]

∃ a constant in cms/djangoapps/contentstore/views/component.py as follows:
SPLIT_TEST_COMPONENT_TYPE = 'split_test' - I would use this reference

[marjev]

I tried to resort to that, but I experience the circular dependancy issue.

I'll try to think of a way to avoid that issue.

[martynjames]

Ah, yes - it's certainly not worth the circular dependency!

[martynjames]

@marjev - A couple of problems I found while testing...
i) Support for searching AB blocks within dashboard - either we need to surpress them, or include the content_groups identifiers in the filter for all courses. (I started to take a stab at this here if it helps - edx@c36e386).
ii) I added a breakpoint to see if I get any results that I need to exclude (Ideally this should not happen) - have not delved deep into this, but maybe this is the Experiment + Cohort case (I have it setup here locally); either way worth investigating.

[marjev]

@martynjames I'll look into that, thanks for the ground work, I'm sure it will prove to be helpful

[openedx-webhooks]

Thanks for the pull request, @marjev! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request.

To automatically create an OSPR issue for this pull request, just visit this link: http://openedx-webhooks.herokuapp.com/github/process_pr?repo=edx%2Fedx-platform&number=8100

[dino-cikatic]

@marjev I believe my latest commit should take care of split_test name and group id issue.

[marjev]

Closing this PR since it's replace by #8229.