Android11 support#558
Merged
Merged
Conversation
Migrated from the deprecated Android Support libraries to the newest versions of the AndroidX libraries. The Android gradle plugin is updated to the current 4.0.0. Glide is updated to the current 4.11.0, and 4.1x.x is needed for AndroidX support.
openid#557 Update dependencies the AndoridX dependencies need to get updated okio (still the Java version) joda Update plugins Android Gradle bintray jacoco checkstyle Support Android 11 (discussed in openid#554 ) Support Intent.CATEGORY_APP_BROWSER The library should still get checked on the oldest supported version.
iainmcgin
approved these changes
Jun 18, 2020
| - build-tools-29.0.2 | ||
| - android-29 | ||
| - build-tools-30.0.0 | ||
| - android-230 |
Member
There was a problem hiding this comment.
Is this a typo? Should it be android-30?
| - ./gradlew check jacoco assemble | ||
| - bash <(curl -s https://codecov.io/bash) | ||
| before_install: | ||
| - yes | sdkmanager "platforms;android-30" |
Member
There was a problem hiding this comment.
Assuming the above android-230 is a typo, this might not be needed anymore?
Member
|
Let's investigate the travis comments in a follow up, so we can get the main thrust of this PR in. |
|
Any timeline when this is beeing released .. last release was 0.7.1 @ Aug 2018 "just asking" because Android 11 is next to my door and asking for sugar.. I fear due to stuck #444 this "one and only official openid reference implementation supported by google is a daredevil ride on a dead horse"... isn't it? |
athilahs
added a commit
to Skyscanner/AppAuth-Android
that referenced
this pull request
Aug 17, 2020
* Minor README fixes (openid#351) Thanks to @celphy for spotting these mistakes. * Add WeWork to AUTHORS WeWork, as my employer, is now the copyright owner for my contributions to AppAuth. * Dependency version bump * Handle CustomTabsSession.newSession failures Fixes openid#315. * Enable Java 8 language features * Do not automatically pass scope on token exchange request Fixes openid#297. * Do not override tab title setting Fixes openid#358. * Firefox customtabs (openid#378) Add support for custom tabs in Firefox. Support for custom tabs was added to stable Firefox in version 57.0 Fixes: openid#368 Signed-off-by: Henning Nielsen Lund <henning.n.lund@jp.dk> * Respect default browser of the user (openid#379) Correctly orders the user's preferred browser to the start of the returned list. * Custom Tabs was first added in Samsung Internet 4.0 (openid#383) At the moment all versions of the Samsung Internet Browser is set to support Custom Tabs. Support for Custom Tabs was first added in version 4.0. fixes: openid#382 * add getBrowserDescriptor() (openid#388) Make it possible to get the BrowserDescriptor used by AuthorizationService. fixes: openid#387 Signed-off-by: Henning Nielsen Lund <henning.n.lund@jp.dk> * Android gradle plugin version bump * Implement ID Token validation according to OIDC spec (openid#385) Validate ID Tokens (if any) on TokenResponses according to http://openid.net/specs/openid-connect-core-1_0.html#IDTokenValidation * Add Øyvind to the contributors list * Update CONTRIBUTORS with email (openid#397) * Use CustomTabsService.ACTION_CUSTOM_TABS_CONNECTION in BrowserSelector. (openid#411) * This helps with the jetification. I produced an artifact locally, and wrote a sample app using: ```gradle implementation 'androidx.appcompat:appcompat:1.0.0-rc02' implementation 'androidx.browser:browser:1.0.0-rc02' ``` to make sure that the app works. Fixes: openid#395 * Issue openid#402: fixes NPE in case input stream is null (openid#414) * Fix spelling mistake * Update link to custom tabs documentation * Fix typo in README.md (openid#455) * Fix `Using access tokens` snippet in the readme (openid#510) The snippet code in the `Using access tokens` section didn't follow java code formatting. * Use capitalized form for "Bearer" token type While this is case-insensitive, some provider implementations do not correctly handle the lower case form. * Migrate to AndroidX & Update dependencies (openid#508) * gradle update to 5.4.1 * gradle plugin update to 3.5.3 * minor bintray update * bump compile sdk to 29 - this requires bumping build tools to 29 - also updating the gradlewrapper (again, fully) to 5.4.1 * Migrate to AndroidX This required changes to checkstyle & javadocs gradle files (perhaps because of jetifier? not sure tbh) Also mockito now can mock all final classes * Fix compiler warning * update travis build tools to 29.0.2 to align with build.gradle * update travis android sdk version to 29 to align with build.gradle * Android11 support (openid#558) - Migrated from the deprecated Android Support libraries to the newest versions of the AndroidX libraries. - The Android gradle plugin is updated to the current 4.0.0. - Glide is updated to the current 4.11.0, and 4.1x.x is needed for AndroidX support. - limit the allowed queries to only fullbrowsers - openid#554 . - Add support for CATEGORY_APP_BROWSER. - Update dependencies * Deprecate whitelist and blacklist (openid#555) * Replace BrowserBlacklist with BrowserDenyList and BrowserWhitelist with BrowserAllowList * Add xmlpull library dependency for tests because some of the unit tests fail without it. * Override constructors and add a deprecation migration test * Update library version to 0.8.0-skyscanner * Fix build after upgrading gradle plugin (as result of syncing up with openid repo) Co-authored-by: Iain McGinniss <iainmcgin@gmail.com> Co-authored-by: Iain McGinniss <iain.mcginniss@wework.com> Co-authored-by: Henning Lund <40355805+hnljp@users.noreply.github.com> Co-authored-by: Øyvind Robertsen <oyvindrobertsen@gmail.com> Co-authored-by: Rahul Ravikumar <tikurahul@users.noreply.github.com> Co-authored-by: Thomas Rebouillon <thomas.rebouillon@gmail.com> Co-authored-by: Mark Kowalski <mark.kowalski86@googlemail.com> Co-authored-by: Ahmad El-Melegy <ahmad.melegy@gmail.com> Co-authored-by: Paul Blundell <blundell.app.dev@gmail.com> Co-authored-by: Jon F Hancock <jonfhancock@gmail.com> Co-authored-by: Athila Santos <athilahs>
This was referenced Sep 23, 2020
Closed
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made a merge of my pullrequest, with the current master and updated it.
See issues:
#557
#554