Replacing endf c functions with package - #3101
Merged
paulromano merged 2 commits intoAug 14, 2024
Merged
Conversation
This was referenced Aug 8, 2024
jon-proximafusion
force-pushed
the
replacing_endf_c_functions_with_package
branch
from
August 13, 2024 22:30
d3efb24 to
c03a236
Compare
paulromano
approved these changes
Aug 14, 2024
paulromano
left a comment
paulromano
left a comment
Contributor
There was a problem hiding this comment.
LGTM. And now that the endf package is on conda-forge, there should be no problems once we get to release time 👍
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Paul made this fab python endf package. It includes the
float_endffunction that we have in openmc. One key difference is that the endf package is pip installable and makes use of pybind11 to link the cpp with the python side.Removing the local
float_endfand replacing it with thefloat_endffrom this package would be really useful for making openmc pip installable. This would help avoid some of the complicated cython useage when making the wheelFixes # (issue)
Checklist