Remove resonance reconstruction and Cython dependency - #3111
Conversation
|
Are any of the features in |
|
ah sorry I should have added some more context here. I saw Paul at the open source workshop last week and asked what were the options for these files. They are not in Pauls endf package. However the files were added when |
|
To add some more context here — the Cython code in question that performs resonance reconstruction was added (#721) at a time when NJOY was not yet open sourced and there was a thought that perhaps we would do all our nuclear data processing "in house". However, shortly after this was merged, NJOY became open source and thus the resonance reconstruction in OpenMC sort of lost its raison d'être. It's also worth noting that what we have in OpenMC is also incomplete (doesn't handle LRF=7) and sometimes incorrect (see original description in #721). So, with that being said, I am not at all opposed to chopping this block of code and removing our dependence on Cython. |
shimwell
left a comment
There was a problem hiding this comment.
super super, this will be really helpful, thanks for finishing the PR Paul
Congrats on your first PR @jon-proximafusion 😄 hope it will be the first of many
Will merge when tests pass
paulromano
left a comment
There was a problem hiding this comment.
Thanks for taking care of this @jon-proximafusion!
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
Description
This PR aims to remove the reconstruct.pyx file and associated usage.
If I remember the correctly then this file was made before njoy was opensource and openmc performed some nuclear data processes
Now njoy is open source this functionality is no longer needed.
If both this PR and PR #3101 are successful then this helps making the pypi pip packaging easier as we can remove the cython from the code.
Checklist