OCPBUGS-85148, NE-2395: Fix e2e tests to work on platforms with unmanaged DNS by rikatz · Pull Request #1342 · openshift/cluster-ingress-operator

rikatz · 2026-01-15T13:22:43Z

On on-prem platforms we cannot assure that the DNS record will always work. On some platforms the DNS controller is created with a fake controller, and DNSRecords never gets ready. In these cases, what we need is that the tests rely on the Gateway status address as a name and connect to it directly instead of trying to resolve the DNS.

This change creates a new function to verify if the test is running on a platform with unmanaged DNS, and in this case it skips verifying DNSRecord and makes the resolution of DNS records be hardcoded to use the gateway address on the http client

openshift-ci-robot · 2026-01-15T13:22:48Z

@rikatz: This pull request references NE-2395 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

On on-prem platforms we cannot assure that the DNS record will always work. On some platforms the DNS controller is created with a fake controller, and DNSRecords never gets ready. In these cases, what we need is that the tests rely on the Gateway status address as a name and connect to it directly instead of trying to resolve the DNS.

This change creates a new function to verify if the test is running on a platform with unmanaged DNS, and in this case it skips verifying DNSRecord and makes the resolution of DNS records be hardcoded to use the gateway address on the http client

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rikatz · 2026-01-15T16:41:14Z

Executed test on a vsphere cluster:

kubectl exec -it launch-clusterbot-wait -c test -- /tmp/e2e -test.run TestGatewayAPI -test.v
--- PASS: TestGatewayAPI (381.23s)
    --- PASS: TestGatewayAPI/testGatewayAPIResources (46.41s)
    --- PASS: TestGatewayAPI/testGatewayAPIObjects (53.42s)
    --- PASS: TestGatewayAPI/testGatewayAPIManualDeployment (10.07s)
    --- PASS: TestGatewayAPI/testGatewayAPIIstioInstallation (14.15s)
    --- SKIP: TestGatewayAPI/testGatewayAPIDNS (1.01s)
    --- SKIP: TestGatewayAPI/testGatewayAPIDNSListenerUpdate (1.01s)
    --- PASS: TestGatewayAPI/testGatewayAPIDNSListenerWithNoHostname (96.05s)
    --- PASS: TestGatewayAPI/testGatewayAPIResourcesProtection (87.86s)
        --- PASS: TestGatewayAPI/testGatewayAPIResourcesProtection/Ingress_operator_service_account_required (10.33s)
        --- PASS: TestGatewayAPI/testGatewayAPIResourcesProtection/Pod_binding_required (10.37s)
    --- PASS: TestGatewayAPI/testGatewayAPIRBAC (0.05s)
    --- PASS: TestGatewayAPI/testOperatorDegradedCondition (67.17s)

How to execute the test:

Compile the e2e test with go test -c -o e2e -tags e2e ./test/e2e/
Get a cluster of type vsphere, static and get the IPs (as per Add e2e-vsphere-static-metallb-operator release#73349)
Install MetalLB with the static IPs on this cluster (still check the pipeline above)
Get the kubeconfig of the build cluster
With that kubeconfig, copy the e2e and run:

kubectl cp e2e launch-clusterbot-wait:/tmp/ -c test
kubectl exec -it launch-clusterbot-wait -c test -- /tmp/e2e -test.run TestGatewayAPI -test.v

gcs278 · 2026-01-15T18:49:21Z

I'd like to take a look
/assign

rikatz · 2026-01-15T20:10:32Z

failing tests do not seem related to my changes. BTW my changes are working on all of "*-operator" pipelines (that are the ones covered by test/e2e here)

lihongan · 2026-01-16T01:27:09Z

/retest-required

gcs278

Looks good! All of my comments are mostly nits about style, feel free to take or leave them. I agree with the approach overall.

lihongan · 2026-01-16T06:51:00Z

The TestGatewayAPI passed in the e2e-aws-operator job , the failing test is TestAWSLBTypeChange and might be related to #1142

         --- FAIL: TestAll/parallel/TestAWSLBTypeChange (381.82s) 
--- PASS: TestAll/serial/TestGatewayAPI (810.88s)

gcs278 · 2026-01-16T21:12:34Z

Thanks for the updates! Yea @lihongan is right, the TestAWSLBTypeChange failure is due to openshift/cluster-cloud-controller-manager-operator#362 merging, and our fix needs to merge: #1142. Though, I'm not sure about the TestCanaryRoute, that seems unrelated.

/lgtm

rikatz · 2026-01-16T22:14:39Z

is the canary one related to #1334 ?

candita · 2026-01-21T15:39:24Z

/assign @grzpiotrowski

grzpiotrowski

/approve

openshift-ci · 2026-01-22T17:25:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grzpiotrowski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [grzpiotrowski]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

melvinjoseph86 · 2026-01-24T18:16:07Z

/retest

On on-prem platforms we cannot assure that the DNS record will always work. On some platforms the DNS controller is created with a fake controller, and DNSRecords never gets ready. In these cases, what we need is that the tests rely on the Gateway status address as a name and connect to it directly instead of trying to resolve the DNS. This change creates a new function to verify if the test is running on a platform with unmanaged DNS, and in this case it skips verifying DNSRecord and makes the resolution of DNS records be hardcoded to use the gateway address on the http client

This commit fixes some validation on Azure verification for managed DNS and also on some logging messages

AWS managed DNS can rely on tags instead of IDs to define if a zone is managed. This change adds the validation of a tag being also defined

rikatz · 2026-01-26T20:24:29Z

@gcs278 if possible I need a new lgtm, the only change was rebasing over master to get your fixes on the TestLBChange

/cc @lihongan @ShudiLi @rhamini3 @melvinjoseph86
for QE verified label

thanks folks!

gcs278 · 2026-01-26T20:42:46Z

/lgtm

rhamini3 · 2026-01-26T21:15:25Z

rebased over master to get Grant's fix
/verified by e2e

openshift-ci-robot · 2026-01-26T21:15:38Z

@rhamini3: This PR has been marked as verified by e2e.

Details

In response to this:

rebased over master to get Grant's fix
/verified by e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-01-26T22:33:17Z

/retest-required

Remaining retests: 0 against base HEAD 6ea8127 and 2 for PR HEAD 0c08ea1 in total

openshift-ci-robot · 2026-01-27T00:33:19Z

/retest-required

Remaining retests: 0 against base HEAD ea67a8c and 1 for PR HEAD 0c08ea1 in total

openshift-ci · 2026-01-27T08:38:31Z

@rikatz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

rikatz · 2026-01-27T12:34:02Z

/cherry-pick release-4.21

openshift-cherrypick-robot · 2026-01-27T12:34:55Z

@rikatz: new pull request created: #1352

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2026-05-06T17:48:18Z

@rikatz: Jira Issue Verification Checks: Jira Issue OCPBUGS-85148
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-85148 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

On on-prem platforms we cannot assure that the DNS record will always work. On some platforms the DNS controller is created with a fake controller, and DNSRecords never gets ready. In these cases, what we need is that the tests rely on the Gateway status address as a name and connect to it directly instead of trying to resolve the DNS.

This change creates a new function to verify if the test is running on a platform with unmanaged DNS, and in this case it skips verifying DNSRecord and makes the resolution of DNS records be hardcoded to use the gateway address on the http client

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rikatz · 2026-05-06T17:48:19Z

/jira refresh

openshift-ci-robot · 2026-05-06T17:48:23Z

@rikatz: Jira Issue OCPBUGS-85148 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rikatz · 2026-05-06T17:50:21Z

/cherry-pick release-4.21

openshift-cherrypick-robot · 2026-05-06T17:51:05Z

@rikatz: new pull request created: #1437

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

rikatz · 2026-05-06T17:56:55Z

/cherry-pick release-4.20

openshift-cherrypick-robot · 2026-05-06T17:57:36Z

@rikatz: #1342 failed to apply on top of branch "release-4.20":

Applying: NE-2395: Fix e2e tests to work on platforms with unmanaged DNS
Using index info to reconstruct a base tree...
M	test/e2e/gateway_api_test.go
M	test/e2e/util_gatewayapi_test.go
M	test/e2e/util_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/util_test.go
Auto-merging test/e2e/util_gatewayapi_test.go
Auto-merging test/e2e/gateway_api_test.go
CONFLICT (content): Merge conflict in test/e2e/gateway_api_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 NE-2395: Fix e2e tests to work on platforms with unmanaged DNS

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

rikatz · 2026-05-06T17:58:57Z

/jira backport release-4.22,release-4.20

openshift-ci-robot · 2026-05-06T17:59:00Z

@rikatz: Missing required branches for backport chain:

openshift-4.21 OR release-4.21,

Details

In response to this:

/jira backport release-4.22,release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rikatz · 2026-05-06T19:29:56Z

/jira backport release-4.20

openshift-ci-robot · 2026-05-06T19:30:02Z

@rikatz: Missing required branches for backport chain:

release-4.21 OR openshift-4.21,

Details

In response to this:

/jira backport release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 15, 2026

openshift-ci Bot requested review from Miciah and bentito January 15, 2026 13:23

rikatz force-pushed the fix-gwapi-e2e-vsphere branch from 6de938d to 956bba7 Compare January 15, 2026 16:37

openshift-ci Bot assigned gcs278 Jan 15, 2026

gcs278 reviewed Jan 16, 2026

View reviewed changes

Comment thread test/e2e/util_test.go Outdated

Comment thread test/e2e/util_test.go Outdated

Comment thread test/e2e/util_test.go Outdated

Comment thread test/e2e/util_gatewayapi_test.go

gcs278 reviewed Jan 16, 2026

View reviewed changes

Comment thread test/e2e/util_test.go Outdated

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2026

openshift-ci Bot assigned grzpiotrowski Jan 21, 2026

grzpiotrowski approved these changes Jan 22, 2026

View reviewed changes

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2026

rikatz added 3 commits January 26, 2026 17:23

Address review comments on on-prem test

411aa23

This commit fixes some validation on Azure verification for managed DNS and also on some logging messages

Add additional validation to AWS managed zone

0c08ea1

AWS managed DNS can rely on tags instead of IDs to define if a zone is managed. This change adds the validation of a tag being also defined

rikatz force-pushed the fix-gwapi-e2e-vsphere branch from 0677b21 to 0c08ea1 Compare January 26, 2026 20:23

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2026

openshift-ci Bot requested review from lihongan and melvinjoseph86 January 26, 2026 20:24

openshift-ci Bot requested review from ShudiLi and rhamini3 January 26, 2026 20:24

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 26, 2026

openshift-merge-bot Bot merged commit 9963c95 into openshift:master Jan 27, 2026
16 checks passed

openshift-cherrypick-robot mentioned this pull request Jan 27, 2026

[release-4.21] NE-2395: Fix e2e tests to work on platforms with unmanaged DNS #1352

Closed

gcs278 mentioned this pull request Mar 31, 2026

NE-2520: Enable Gateway API tests on vSphere and baremetal openshift/origin#30946

Merged

rikatz changed the title ~~NE-2395: Fix e2e tests to work on platforms with unmanaged DNS~~ OCPBUGS-85148, NE-2395: Fix e2e tests to work on platforms with unmanaged DNS May 6, 2026

openshift-cherrypick-robot mentioned this pull request May 6, 2026

[release-4.21] OCPBUGS-85149: Fix e2e tests to work on platforms with unmanaged DNS #1437

Open

rikatz mentioned this pull request May 6, 2026

[release-4.20] OCPBUGS-85155: Fix e2e tests to work on platforms with unmanaged DNS #1438

Open

Conversation

rikatz commented Jan 15, 2026

Uh oh!

openshift-ci-robot commented Jan 15, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rikatz commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gcs278 commented Jan 15, 2026

Uh oh!

rikatz commented Jan 15, 2026

Uh oh!

lihongan commented Jan 16, 2026

Uh oh!

gcs278 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lihongan commented Jan 16, 2026

Uh oh!

Uh oh!

gcs278 commented Jan 16, 2026

Uh oh!

rikatz commented Jan 16, 2026

Uh oh!

candita commented Jan 21, 2026

Uh oh!

grzpiotrowski left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Jan 22, 2026

Uh oh!

melvinjoseph86 commented Jan 24, 2026

Uh oh!

rikatz commented Jan 26, 2026

Uh oh!

gcs278 commented Jan 26, 2026

Uh oh!

rhamini3 commented Jan 26, 2026

Uh oh!

openshift-ci-robot commented Jan 26, 2026

Uh oh!

openshift-ci-robot commented Jan 26, 2026

Uh oh!

openshift-ci-robot commented Jan 27, 2026

Uh oh!

openshift-ci Bot commented Jan 27, 2026

Uh oh!

Uh oh!

rikatz commented Jan 27, 2026

Uh oh!

openshift-cherrypick-robot commented Jan 27, 2026

Uh oh!

openshift-ci-robot commented May 6, 2026

Uh oh!

rikatz commented May 6, 2026

Uh oh!

openshift-ci-robot commented May 6, 2026

Uh oh!

rikatz commented May 6, 2026

Uh oh!

openshift-cherrypick-robot commented May 6, 2026

Uh oh!

rikatz commented May 6, 2026

Uh oh!

openshift-cherrypick-robot commented May 6, 2026

Uh oh!

rikatz commented May 6, 2026

Uh oh!

openshift-ci-robot commented May 6, 2026

Uh oh!

rikatz commented May 6, 2026

Uh oh!

openshift-ci-robot commented May 6, 2026

Uh oh!

Reviewers

openshift-ci-robot commented Jan 15, 2026 •

edited by openshift-ci Bot

Loading

rikatz commented Jan 15, 2026 •

edited

Loading