[release-4.21] OCPBUGS-85149: Fix e2e tests to work on platforms with unmanaged DNS by openshift-cherrypick-robot · Pull Request #1437 · openshift/cluster-ingress-operator

openshift-cherrypick-robot · 2026-05-06T17:51:03Z

This is an automated cherry-pick of #1342

/assign rikatz

On on-prem platforms we cannot assure that the DNS record will always work. On some platforms the DNS controller is created with a fake controller, and DNSRecords never gets ready. In these cases, what we need is that the tests rely on the Gateway status address as a name and connect to it directly instead of trying to resolve the DNS. This change creates a new function to verify if the test is running on a platform with unmanaged DNS, and in this case it skips verifying DNSRecord and makes the resolution of DNS records be hardcoded to use the gateway address on the http client

This commit fixes some validation on Azure verification for managed DNS and also on some logging messages

AWS managed DNS can rely on tags instead of IDs to define if a zone is managed. This change adds the validation of a tag being also defined

coderabbitai · 2026-05-06T17:51:11Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d6d6872b-668e-4209-84af-94d924a510fb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-05-06T17:51:36Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign miciah for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-05-06T17:52:14Z

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: NE-2395
Jira Issue OCPBUGS-85148 has been cloned as Jira Issue OCPBUGS-85149. Will retitle bug to link to clone.

WARNING: Unexpected sprint field type []interface {} on source issue. Please update sprint manually on clone.

/retitle [release-4.21] OCPBUGS-85149, NE-2395: Fix e2e tests to work on platforms with unmanaged DNS

Details

In response to this:

This is an automated cherry-pick of #1342

/assign rikatz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-05-06T17:52:25Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-85149, which is invalid:

expected dependent Jira Issue OCPBUGS-85148 to target a version in 4.22.0, but it targets "4.21.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references NE-2395 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.z" version, but no target version was set.

Details

In response to this:

This is an automated cherry-pick of #1342

/assign rikatz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rikatz · 2026-05-06T17:53:03Z

/jira refresh

openshift-ci-robot · 2026-05-06T17:53:08Z

@rikatz: This pull request references Jira Issue OCPBUGS-85149, which is invalid:

expected dependent Jira Issue OCPBUGS-85148 to target a version in 4.22.0, but it targets "4.22.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references NE-2395 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.z" version, but no target version was set.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rikatz · 2026-05-06T17:55:20Z

/jira refresh

openshift-ci-robot · 2026-05-06T17:55:28Z

@rikatz: This pull request references Jira Issue OCPBUGS-85149, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.z) matches configured target version for branch (4.21.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-85148 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-85148 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
bug has dependents

Requesting review from QA contact:
/cc @melvinjoseph86

This pull request references NE-2395 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.z" version, but no target version was set.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rikatz · 2026-05-06T19:30:54Z

/jira backport release-4.20

openshift-ci-robot · 2026-05-06T19:32:04Z

@rikatz: Failed to create backported issues:

WARNING: Unexpected sprint field type []interface {} on source issue. Please update sprint manually on clone.

Details

In response to this:

/jira backport release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

candita · 2026-05-06T22:42:25Z

@rikatz why is the bug title "Gateway API should be tested against vSphere environments" ? This repo doesn't even have vsphere tests. You would need to add a vsphere test.

rikatz · 2026-05-07T11:47:50Z

renamed to "Fix e2e tests to work on platforms with unmanaged DNS" to reflect the cherrypick title

rikatz · 2026-05-07T11:47:55Z

/retest-required

rikatz · 2026-05-07T12:24:44Z

/retitle [release-4.21] OCPBUGS-85149: Fix e2e tests to work on platforms with unmanaged DNS

openshift-ci-robot · 2026-05-07T12:25:10Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-85149, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.z) matches configured target version for branch (4.21.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-85148 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-85148 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
bug has dependents

Requesting review from QA contact:
/cc @melvinjoseph86

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1342

/assign rikatz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rikatz · 2026-05-07T16:57:39Z

/retest-required

openshift-ci · 2026-05-07T18:24:19Z

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-pre-release-ossm	`872e33d`	link	false	`/test e2e-aws-pre-release-ossm`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

rikatz · 2026-05-07T23:17:37Z

/retest-required

rikatz added 3 commits May 6, 2026 17:51

Address review comments on on-prem test

04902c5

This commit fixes some validation on Azure verification for managed DNS and also on some logging messages

Add additional validation to AWS managed zone

872e33d

AWS managed DNS can rely on tags instead of IDs to define if a zone is managed. This change adds the validation of a tag being also defined

openshift-cherrypick-robot assigned rikatz May 6, 2026

openshift-cherrypick-robot mentioned this pull request May 6, 2026

OCPBUGS-85148, NE-2395: Fix e2e tests to work on platforms with unmanaged DNS #1342

Merged

openshift-ci Bot requested review from Miciah and alebedev87 May 6, 2026 17:51

openshift-ci Bot changed the title ~~[release-4.21] OCPBUGS-85148, NE-2395: Fix e2e tests to work on platforms with unmanaged DNS~~ [release-4.21] OCPBUGS-85149, NE-2395: Fix e2e tests to work on platforms with unmanaged DNS May 6, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 6, 2026

openshift-ci Bot requested a review from melvinjoseph86 May 6, 2026 17:55

openshift-ci Bot changed the title ~~[release-4.21] OCPBUGS-85149, NE-2395: Fix e2e tests to work on platforms with unmanaged DNS~~ [release-4.21] OCPBUGS-85149: Fix e2e tests to work on platforms with unmanaged DNS May 7, 2026

Conversation

openshift-cherrypick-robot commented May 6, 2026

Uh oh!

coderabbitai Bot commented May 6, 2026

Review skipped

Uh oh!

openshift-ci Bot commented May 6, 2026

Uh oh!

openshift-ci-robot commented May 6, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented May 6, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rikatz commented May 6, 2026

Uh oh!

openshift-ci-robot commented May 6, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rikatz commented May 6, 2026

Uh oh!

openshift-ci-robot commented May 6, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rikatz commented May 6, 2026

Uh oh!

openshift-ci-robot commented May 6, 2026

Uh oh!

candita commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rikatz commented May 7, 2026

Uh oh!

rikatz commented May 7, 2026

Uh oh!

rikatz commented May 7, 2026

Uh oh!

openshift-ci-robot commented May 7, 2026

Uh oh!

rikatz commented May 7, 2026

Uh oh!

openshift-ci Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rikatz commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

openshift-ci-robot commented May 6, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented May 6, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented May 6, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented May 6, 2026 •

edited by openshift-ci Bot

Loading

candita commented May 6, 2026 •

edited

Loading

openshift-ci Bot commented May 7, 2026 •

edited

Loading