Skip to content

USHIFT-704: add aggregate-route cluster role#1981

Merged
openshift-merge-robot merged 1 commit into
openshift:mainfrom
chiragkyal:USHIFT-704
Jul 3, 2023
Merged

USHIFT-704: add aggregate-route cluster role#1981
openshift-merge-robot merged 1 commit into
openshift:mainfrom
chiragkyal:USHIFT-704

Conversation

@chiragkyal

@chiragkyal chiragkyal commented Jun 30, 2023

Copy link
Copy Markdown
Member

Which issue(s) this PR addresses:

Closes #USHIFT-704

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 30, 2023
@openshift-ci-robot

openshift-ci-robot commented Jun 30, 2023

Copy link
Copy Markdown

@chiragkyal: This pull request references USHIFT-704 which is a valid jira issue.

Details

In response to this:

Which issue(s) this PR addresses:

Closes #USHIFT-704

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2023
@openshift-ci

openshift-ci Bot commented Jun 30, 2023

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot

openshift-ci-robot commented Jun 30, 2023

Copy link
Copy Markdown

@chiragkyal: This pull request references USHIFT-704 which is a valid jira issue.

Details

In response to this:

Which issue(s) this PR addresses:

Closes #USHIFT-704

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2023
@dhellmann

Copy link
Copy Markdown
Contributor

This looks right. I think you have to take the PR out of draft mode to have the tests run, though.

Do any of our CI jobs run the test that is fixed with this change?

@chiragkyal chiragkyal marked this pull request as ready for review July 3, 2023 12:52
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2023
@openshift-ci openshift-ci Bot requested review from dhellmann and pliurh July 3, 2023 12:54
@chiragkyal

Copy link
Copy Markdown
Member Author

Do any of our CI jobs run the test that is fixed with this change?

Not yet, I belive.
We need to test them locally for now.

@dhellmann

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2023
@openshift-ci

openshift-ci Bot commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chiragkyal, dhellmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [chiragkyal,dhellmann]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chiragkyal chiragkyal changed the title USHIFT-704: [WIP] add aggregate-route cluster role USHIFT-704: add aggregate-route cluster role Jul 3, 2023
@openshift-ci

openshift-ci Bot commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

@chiragkyal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-reduced-arm 858509b link false /test e2e-openshift-conformance-reduced-arm
ci/prow/microshift-e2e-arm 858509b link false /test microshift-e2e-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chiragkyal

Copy link
Copy Markdown
Member Author

A fix to this PR was added in #2002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants