Skip to content

USHIFT-704: fix rebase asset.yaml for aggregate-route#2002

Merged
openshift-merge-robot merged 1 commit into
openshift:mainfrom
chiragkyal:fix-704
Jul 6, 2023
Merged

USHIFT-704: fix rebase asset.yaml for aggregate-route#2002
openshift-merge-robot merged 1 commit into
openshift:mainfrom
chiragkyal:fix-704

Conversation

@chiragkyal

@chiragkyal chiragkyal commented Jul 6, 2023

Copy link
Copy Markdown
Member

Which issue(s) this PR addresses:

Closes #USHIFT-704

/assign @pmtk

@openshift-ci-robot

openshift-ci-robot commented Jul 6, 2023

Copy link
Copy Markdown

@chiragkyal: This pull request references USHIFT-704 which is a valid jira issue.

Details

In response to this:

Which issue(s) this PR addresses:

Closes #USHIFT-704

/assign @pmtk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 6, 2023
@openshift-ci-robot

openshift-ci-robot commented Jul 6, 2023

Copy link
Copy Markdown

@chiragkyal: This pull request references USHIFT-704 which is a valid jira issue.

Details

In response to this:

Which issue(s) this PR addresses:

Closes #USHIFT-704

/assign @pmtk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from copejon and jerpeter1 July 6, 2023 06:43
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2023
@openshift-ci

openshift-ci Bot commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

@chiragkyal: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pmtk

pmtk commented Jul 6, 2023

Copy link
Copy Markdown
Member

Looks good, log from test-rebase:

2023-07-06 06:59:13,162     INFO       Restoring assets/components/openshift-router/cluster-role-aggregate-route.yaml
2023-07-06 06:59:13,162     DEBUG      Executing 'git restore assets/components/openshift-router/cluster-role-aggregate-route.yaml'

/lgtm

@pmtk

pmtk commented Jul 6, 2023

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2023
@openshift-ci

openshift-ci Bot commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chiragkyal, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants