🌱 OCPBUGS-60693, OCPBUGS-60958: Upgrade sigs.k8s.io/crdify v0.5.0 => v0.5.1-0.20260309184313-54162f2e3097 and add tests to ensure bug fix scenarios#2612
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR updates the sigs.k8s.io/crdify module dependency used by the operator-controller codebase to a newer pseudo-version, reflecting an upstream change without modifying any internal logic.
Changes:
- Bump
sigs.k8s.io/crdifyfromv0.5.0tov0.5.1-0.20260309184313-54162f2e3097ingo.mod. - Update
go.sumchecksums to match the newcrdifyversion.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updates the required sigs.k8s.io/crdify version to the newer pseudo-version. |
| go.sum | Refreshes module checksums for the updated sigs.k8s.io/crdify dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c537529 to
33ce7c8
Compare
33ce7c8 to
91aef46
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...controller/rukpak/preflights/crdupgradesafety/testdata/manifests/crd-optional-field-new.json
Show resolved
Hide resolved
...controller/rukpak/preflights/crdupgradesafety/testdata/manifests/crd-optional-field-new.json
Show resolved
Hide resolved
...controller/rukpak/preflights/crdupgradesafety/testdata/manifests/crd-optional-field-new.json
Show resolved
Hide resolved
...controller/rukpak/preflights/crdupgradesafety/testdata/manifests/crd-optional-field-new.json
Show resolved
Hide resolved
91aef46 to
d6b13f7
Compare
d6b13f7 to
e04962a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e04962a to
92434e2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2612 +/- ##
==========================================
- Coverage 68.86% 68.83% -0.03%
==========================================
Files 139 139
Lines 9872 9930 +58
==========================================
+ Hits 6798 6835 +37
- Misses 2557 2579 +22
+ Partials 517 516 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…309184313-54162f2e3097
92434e2 to
f5dedc1
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
internal/operator-controller/rukpak/preflights/crdupgradesafety/crdupgradesafety_test.go
Show resolved
Hide resolved
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rashmigottipati, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ba1e4cb
into
operator-framework:main
No description provided.