-
Notifications
You must be signed in to change notification settings - Fork 73
🌱 OCPBUGS-60693, OCPBUGS-60958: Upgrade sigs.k8s.io/crdify v0.5.0 => v0.5.1-0.20260309184313-54162f2e3097 and add tests to ensure bug fix scenarios #2612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
openshift-merge-bot
merged 3 commits into
operator-framework:main
from
camilamacedo86:bump-crddiff
Mar 31, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
106 changes: 106 additions & 0 deletions
106
...kpak/preflights/crdupgradesafety/testdata/manifests/crd-complex-breaking-changes-new.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| { | ||
| "apiVersion": "apiextensions.k8s.io/v1", | ||
| "kind": "CustomResourceDefinition", | ||
| "metadata": { | ||
| "name": "services.networking.example.com" | ||
| }, | ||
| "spec": { | ||
| "group": "networking.example.com", | ||
| "versions": [ | ||
| { | ||
| "name": "v1beta1", | ||
| "served": true, | ||
| "storage": true, | ||
| "schema": { | ||
| "openAPIV3Schema": { | ||
| "type": "object", | ||
| "properties": { | ||
| "spec": { | ||
| "type": "object", | ||
| "properties": { | ||
| "ingress": { | ||
| "type": "object", | ||
| "properties": { | ||
| "gateway": { | ||
| "type": "object", | ||
| "properties": { | ||
| "servers": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "object", | ||
| "properties": { | ||
| "hosts": { | ||
| "description": "One or more hosts exposed by this gateway", | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "port": { | ||
| "type": "object", | ||
| "properties": { | ||
| "name": { | ||
| "description": "Label assigned to the port", | ||
| "type": "string" | ||
| }, | ||
| "number": { | ||
| "description": "Port number", | ||
| "type": "integer" | ||
| } | ||
| } | ||
| }, | ||
| "tls": { | ||
| "nullable": true, | ||
| "oneOf": [ | ||
| { | ||
| "required": ["mode", "credentialName"] | ||
| }, | ||
| { | ||
| "required": ["httpsRedirect"] | ||
| } | ||
| ], | ||
| "properties": { | ||
| "credentialName": { | ||
| "description": "TLS certificate name", | ||
| "type": "string" | ||
| }, | ||
| "httpsRedirect": { | ||
| "description": "If set to true, the load balancer will send a 301 redirect to HTTPS", | ||
| "type": "boolean" | ||
| }, | ||
| "mode": { | ||
| "description": "TLS mode", | ||
| "type": "string" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "scope": "Namespaced", | ||
| "names": { | ||
| "plural": "services", | ||
| "singular": "service", | ||
| "kind": "Service", | ||
| "shortNames": [ | ||
| "svc" | ||
| ] | ||
| } | ||
| }, | ||
| "status": { | ||
| "storedVersions": [ | ||
| "v1beta1" | ||
| ] | ||
| } | ||
| } |
95 changes: 95 additions & 0 deletions
95
...kpak/preflights/crdupgradesafety/testdata/manifests/crd-complex-breaking-changes-old.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| { | ||
| "apiVersion": "apiextensions.k8s.io/v1", | ||
| "kind": "CustomResourceDefinition", | ||
| "metadata": { | ||
| "name": "services.networking.example.com" | ||
| }, | ||
| "spec": { | ||
| "group": "networking.example.com", | ||
| "versions": [ | ||
| { | ||
| "name": "v1beta1", | ||
| "served": true, | ||
| "storage": true, | ||
| "schema": { | ||
| "openAPIV3Schema": { | ||
| "type": "object", | ||
| "properties": { | ||
| "spec": { | ||
| "type": "object", | ||
| "properties": { | ||
| "ingress": { | ||
| "type": "object", | ||
| "properties": { | ||
| "gateway": { | ||
| "type": "object", | ||
| "properties": { | ||
| "servers": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "object", | ||
| "properties": { | ||
| "hosts": { | ||
| "description": "One or more hosts exposed by this gateway", | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "port": { | ||
| "type": "object", | ||
| "properties": { | ||
| "name": { | ||
| "description": "Label assigned to the port", | ||
| "type": "string" | ||
| }, | ||
| "number": { | ||
| "description": "Port number", | ||
| "type": "integer" | ||
| } | ||
| } | ||
| }, | ||
| "tls": { | ||
| "type": "object", | ||
| "nullable": false, | ||
| "properties": { | ||
| "credentialName": { | ||
| "description": "TLS certificate name", | ||
| "type": "string" | ||
| }, | ||
| "mode": { | ||
| "description": "TLS mode", | ||
| "type": "string" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "scope": "Namespaced", | ||
| "names": { | ||
| "plural": "services", | ||
| "singular": "service", | ||
| "kind": "Service", | ||
| "shortNames": [ | ||
| "svc" | ||
| ] | ||
| } | ||
| }, | ||
| "status": { | ||
| "storedVersions": [ | ||
| "v1beta1" | ||
| ] | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.