🌱 Skip deploying unused default catalog in e2e tests#2623
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
openshift-ci
bot
added
the
needs-rebase
There was a problem hiding this comment.
Pull request overview
Disables deployment of the unused operatorhubio default catalog during e2e test setup to reduce setup time and remove an unnecessary dependency on quay.io/operatorhubio/catalog:latest.
Changes:
- Set
INSTALL_DEFAULT_CATALOGS := falsefortest-e2e - Set
INSTALL_DEFAULT_CATALOGS := falsefortest-experimental-e2e
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| test-e2e: GO_BUILD_EXTRA_FLAGS := -cover | ||
| test-e2e: COVERAGE_NAME := e2e | ||
| test-e2e: export MANIFEST := $(STANDARD_RELEASE_MANIFEST) | ||
| test-e2e: export INSTALL_DEFAULT_CATALOGS := false |
There was a problem hiding this comment.
Using a target-specific export ... := false hard-overrides any user-provided value for INSTALL_DEFAULT_CATALOGS (including make test-e2e INSTALL_DEFAULT_CATALOGS=true), which can make debugging and local experimentation harder. Consider switching to a conditional assignment that still defaults to false but allows callers to override (e.g., test-e2e: INSTALL_DEFAULT_CATALOGS ?= false plus test-e2e: export INSTALL_DEFAULT_CATALOGS, and same for test-experimental-e2e).
| test-experimental-e2e: GO_BUILD_EXTRA_FLAGS := -cover | ||
| test-experimental-e2e: COVERAGE_NAME := experimental-e2e | ||
| test-experimental-e2e: export MANIFEST := $(EXPERIMENTAL_RELEASE_MANIFEST) | ||
| test-experimental-e2e: export INSTALL_DEFAULT_CATALOGS := false |
There was a problem hiding this comment.
Using a target-specific export ... := false hard-overrides any user-provided value for INSTALL_DEFAULT_CATALOGS (including make test-e2e INSTALL_DEFAULT_CATALOGS=true), which can make debugging and local experimentation harder. Consider switching to a conditional assignment that still defaults to false but allows callers to override (e.g., test-e2e: INSTALL_DEFAULT_CATALOGS ?= false plus test-e2e: export INSTALL_DEFAULT_CATALOGS, and same for test-experimental-e2e).
The operatorhubio default catalog is deployed during e2e setup but never used by any test scenario. All tests create their own isolated catalogs. Skip it to save time and remove the external dependency. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pedjak
force-pushed
the
skip-default-catalog-e2e
branch
from
c269f30 to
6ed60aa
Compare
openshift-ci
bot
removed
the
needs-rebase
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2623 +/- ##
==========================================
+ Coverage 63.19% 68.86% +5.66%
==========================================
Files 139 139
Lines 9902 9902
==========================================
+ Hits 6258 6819 +561
+ Misses 3147 2572 -575
- Partials 497 511 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/lgtm |
openshift-ci
bot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rashmigottipati, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit f0a8f5e
into
operator-framework:main
Description
The
operatorhubiodefault catalog is deployed during e2e test setup but is neverused by any test scenario — all tests create their own isolated catalogs from templates.
This PR sets
INSTALL_DEFAULT_CATALOGS := falsefortest-e2eandtest-experimental-e2etargets, matching the existing pattern intest-extension-developer-e2e. This saves setup time and removes anunnecessary external dependency on
quay.io/operatorhubio/catalog:latest.Reviewer Checklist