-
Notifications
You must be signed in to change notification settings - Fork 73
🌱 Skip deploying unused default catalog in e2e tests #2623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -319,6 +319,7 @@ test-e2e: KIND_CLUSTER_NAME := operator-controller-e2e | |
| test-e2e: GO_BUILD_EXTRA_FLAGS := -cover | ||
| test-e2e: COVERAGE_NAME := e2e | ||
| test-e2e: export MANIFEST := $(STANDARD_RELEASE_MANIFEST) | ||
| test-e2e: export INSTALL_DEFAULT_CATALOGS := false | ||
| test-e2e: run-internal image-registry prometheus e2e e2e-coverage kind-clean #HELP Run e2e test suite on local kind cluster | ||
|
|
||
| .PHONY: test-experimental-e2e | ||
|
|
@@ -328,6 +329,7 @@ test-experimental-e2e: KIND_CONFIG := ./kind-config/kind-config-2node.yaml | |
| test-experimental-e2e: GO_BUILD_EXTRA_FLAGS := -cover | ||
| test-experimental-e2e: COVERAGE_NAME := experimental-e2e | ||
| test-experimental-e2e: export MANIFEST := $(EXPERIMENTAL_RELEASE_MANIFEST) | ||
| test-experimental-e2e: export INSTALL_DEFAULT_CATALOGS := false | ||
|
||
| test-experimental-e2e: PROMETHEUS_VALUES := helm/prom_experimental.yaml | ||
| test-experimental-e2e: E2E_TIMEOUT := 15m | ||
| test-experimental-e2e: run-internal image-registry prometheus e2e e2e-coverage kind-clean #HELP Run experimental e2e test suite on local kind cluster | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a target-specific
export ... := falsehard-overrides any user-provided value forINSTALL_DEFAULT_CATALOGS(includingmake test-e2e INSTALL_DEFAULT_CATALOGS=true), which can make debugging and local experimentation harder. Consider switching to a conditional assignment that still defaults tofalsebut allows callers to override (e.g.,test-e2e: INSTALL_DEFAULT_CATALOGS ?= falseplustest-e2e: export INSTALL_DEFAULT_CATALOGS, and same fortest-experimental-e2e).