[tests-only] [full-ci] Adjust drone code to allow for variation of PHP docker images#1139
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
individual-it
approved these changes
Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is code from PR #1138 without actually changing the
owncloudci/phpdocker image. It adds code to just use the first 3 characters of theowncloudci/phpdocker image tag when generating pipeline names and coverage report names.Similar code was done in wopi https://github.com/owncloud/wopi/pull/220 and core owncloud/core#40409
It will be useful to have this merged here in the activity app. Then when we next need to propagate CI code changes to other apps, this will be here.