Skip to content

[full-ci] [tests-only] Fix su exec ci#40409

Merged
phil-davis merged 3 commits into
masterfrom
fix-su-exec-ci
Oct 7, 2022
Merged

[full-ci] [tests-only] Fix su exec ci#40409
phil-davis merged 3 commits into
masterfrom
fix-su-exec-ci

Conversation

@phil-davis

@phil-davis phil-davis commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

Description

  1. su-exec is no longer provided in the owncloud-ci docker images, so do not use it, use setpriv (similar to refactor: replace su-exec/gosu with setpriv owncloud-docker/base#231 )
  2. setpriv is only in Ubuntu 20.04, so use that for running tests. (cherry-picked from [tests-only] Run PHP tests with 7.4-ubuntu20.04 #40385 - we were thinking to do this anyway, and now we have to)
  3. adjust the construction of pipeline names to avoid some names getting longer than 50 characters

This is needed to get CI green again. CI broke when owncloudci/php Docker was rebuilt recently, and base images no longer had su-exec in them.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Oct 7, 2022
@phil-davis
phil-davis requested a review from xoxys October 7, 2022 11:27
@phil-davis

Copy link
Copy Markdown
Contributor Author

Note: this PR explicitly uses the owncloudci/php:7.4-ubuntu20.04 docker image.

owncloudci/php:7.4 uses Ubuntu 18.04 - next week I will think about if we should change that so it uses Ubuntu 20.04. But for now, we want to get CI green.

@phil-davis
phil-davis marked this pull request as ready for review October 7, 2022 11:29
@sonarqubecloud

sonarqubecloud Bot commented Oct 7, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants