Test with guzzle6#837
Merged
Merged
Conversation
phil-davis
force-pushed
the
demo-test-with-guzzle6
branch
from
0bb499a to
d4a76c7
Compare
Codecov Report
@@ Coverage Diff @@
## master #837 +/- ##
=========================================
Coverage 84.38% 84.38%
Complexity 507 507
=========================================
Files 47 47
Lines 1896 1896
=========================================
Hits 1600 1600
Misses 296 296 Continue to review full report at Codecov.
|
11 tasks
Contributor
Author
|
Good, this passes. |
individual-it
force-pushed
the
demo-test-with-guzzle6
branch
from
d4a76c7 to
85c49bf
Compare
individual-it
force-pushed
the
demo-test-with-guzzle6
branch
from
85c49bf to
89362f8
Compare
individual-it
approved these changes
Feb 24, 2020
Member
|
the PR to core was merged, I've deleted the last temporary commit to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
~This is an example of running app acceptance tests with guzzle6. It uses the core acceptance test code in core branch
use-guzzle6-for-acceptance-teststo demonstrate.When that core PR gets merged, then we will need to do the first commit (bump guzzle to 6.5 in
vendor-bin/behat/composer.json) in every app repo, because the apps use the coremasteracceptance test code for many steps. In particular theGivenstep that creates users! The code for that step is different in Guzzle6 and will not work from an app that tries to still use Guzzle5.~See comment below - now this is just the needed change.